feat(block): improve performance for transaction packing

  1. remove unused code
  2. optimize cycle operation

Author: halibobo1205

chainbase/src/main/java/org/tron/core/capsule/BlockCapsule.java

@@ -143,6 +143,13 @@ public void addTransaction(TransactionCapsule pendingTrx) {
     getTransactions().add(pendingTrx);
   }
 
+  public void addAllTransactions(List<TransactionCapsule> pendingTrxs) {
+    List<Transaction> list = pendingTrxs.stream().map(TransactionCapsule::getInstance).collect(
+        Collectors.toList());
+    this.block = this.block.toBuilder().addAllTransactions(list).build();
+    getTransactions().addAll(pendingTrxs);
+  }
+
   public List<TransactionCapsule> getTransactions() {
     return transactions;
   }

chainbase/src/main/java/org/tron/core/capsule/TransactionRetCapsule.java

@@ -1,6 +1,7 @@
 package org.tron.core.capsule;
 
 import com.google.protobuf.InvalidProtocolBufferException;
+import java.util.List;
 import java.util.Objects;
 import lombok.extern.slf4j.Slf4j;
 import org.tron.core.exception.BadItemException;
@@ -29,7 +30,7 @@ public TransactionRetCapsule() {
 
   public TransactionRetCapsule(byte[] data) throws BadItemException {
     try {
-      this.transactionRet = transactionRet.parseFrom(data);
+      this.transactionRet = TransactionRet.parseFrom(data);
     } catch (InvalidProtocolBufferException e) {
       throw new BadItemException("TransactionInfoCapsule proto data parse exception");
     }
@@ -39,6 +40,10 @@ public void addTransactionInfo(TransactionInfo result) {
     this.transactionRet = this.transactionRet.toBuilder().addTransactioninfo(result).build();
   }
 
+  public void addAllTransactionInfos(List<TransactionInfo> results) {
+    this.transactionRet = this.transactionRet.toBuilder().addAllTransactioninfo(results).build();
+  }
+
   @Override
   public byte[] getData() {
     if (Objects.isNull(transactionRet)) {

framework/src/main/java/org/tron/core/db/Manager.java

@@ -1434,7 +1434,6 @@ public BlockCapsule generateBlock(Miner miner, long blockTime, long timeout) {
         MetricKeys.Histogram.BLOCK_GENERATE_LATENCY, address);
     Metrics.histogramObserve(MetricKeys.Histogram.MINER_LATENCY,
         (System.currentTimeMillis() - blockTime) / Metrics.MILLISECONDS_PER_SECOND, address);
-    long postponedTrxCount = 0;
     logger.info("Generate block {} begin", chainBaseManager.getHeadBlockNum() + 1);
 
     BlockCapsule blockCapsule = new BlockCapsule(chainBaseManager.getHeadBlockNum() + 1,
@@ -1456,16 +1455,17 @@ public BlockCapsule generateBlock(Miner miner, long blockTime, long timeout) {
       }
     }
 
-    TransactionRetCapsule transactionRetCapsule = new TransactionRetCapsule(blockCapsule);
-
     Set<String> accountSet = new HashSet<>();
     AtomicInteger shieldedTransCounts = new AtomicInteger(0);
+    List<TransactionCapsule> toBePacked = new ArrayList<>();
+    long currentSize = blockCapsule.getInstance().getSerializedSize();
+    boolean isSort = Args.getInstance().isOpenTransactionSort();
     while (pendingTransactions.size() > 0 || rePushTransactions.size() > 0) {
       boolean fromPending = false;
       TransactionCapsule trx;
       if (pendingTransactions.size() > 0) {
         trx = pendingTransactions.peek();
-        if (Args.getInstance().isOpenTransactionSort()) {
+        if (isSort) {
           TransactionCapsule trxRepush = rePushTransactions.peek();
           if (trxRepush == null || trx.getOrder() >= trxRepush.getOrder()) {
             fromPending = true;
@@ -1501,24 +1501,23 @@ public BlockCapsule generateBlock(Miner miner, long blockTime, long timeout) {
       }
 
       // check the block size
-      if ((blockCapsule.getInstance().getSerializedSize() + trx.getSerializedSize() + 3)
-          > ChainConstant.BLOCK_SIZE) {
-        postponedTrxCount++;
-        continue;
+      if ((currentSize += trx.getSerializedSize() + 2) > ChainConstant.BLOCK_SIZE) {
+        break;
       }
       //shielded transaction
-      if (isShieldedTransaction(trx.getInstance())
+      Transaction transaction = trx.getInstance();
+      if (isShieldedTransaction(transaction)
           && shieldedTransCounts.incrementAndGet() > SHIELDED_TRANS_IN_BLOCK_COUNTS) {
         continue;
       }
       //multi sign transaction
-      Contract contract = trx.getInstance().getRawData().getContract(0);
+      Contract contract = transaction.getRawData().getContract(0);
       byte[] owner = TransactionCapsule.getOwner(contract);
       String ownerAddress = ByteArray.toHexString(owner);
       if (accountSet.contains(ownerAddress)) {
         continue;
       } else {
-        if (isMultiSignTransaction(trx.getInstance())) {
+        if (isMultiSignTransaction(transaction)) {
           accountSet.add(ownerAddress);
         }
       }
@@ -1528,27 +1527,24 @@ public BlockCapsule generateBlock(Miner miner, long blockTime, long timeout) {
       // apply transaction
       try (ISession tmpSession = revokingStore.buildSession()) {
         accountStateCallBack.preExeTrans();
-        TransactionInfo result = processTransaction(trx, blockCapsule);
+        processTransaction(trx, blockCapsule);
         accountStateCallBack.exeTransFinish();
         tmpSession.merge();
-        blockCapsule.addTransaction(trx);
-        if (Objects.nonNull(result)) {
-          transactionRetCapsule.addTransactionInfo(result);
-        }
+        toBePacked.add(trx);
       } catch (Exception e) {
         logger.error("Process trx {} failed when generating block: {}", trx.getTransactionId(),
             e.getMessage());
       }
     }
-
+    blockCapsule.addAllTransactions(toBePacked);
     accountStateCallBack.executeGenerateFinish();
 
     session.reset();
 
     logger.info("Generate block {} success, trxs:{}, pendingCount: {}, rePushCount: {},"
-            + " postponedCount: {}",
+            + " blockSize: {} B",
         blockCapsule.getNum(), blockCapsule.getTransactions().size(),
-        pendingTransactions.size(), rePushTransactions.size(), postponedTrxCount);
+        pendingTransactions.size(), rePushTransactions.size(), currentSize);
 
     blockCapsule.setMerkleRoot();
     blockCapsule.sign(miner.getPrivateKey());
@@ -1641,18 +1637,21 @@ private void processBlock(BlockCapsule block, List<TransactionCapsule> txs)
     try {
       merkleContainer.resetCurrentMerkleTree();
       accountStateCallBack.preExecute(block);
+      List<TransactionInfo> results = new ArrayList<>();
+      long num = block.getNum();
       for (TransactionCapsule transactionCapsule : block.getTransactions()) {
-        transactionCapsule.setBlockNum(block.getNum());
+        transactionCapsule.setBlockNum(num);
         if (block.generatedByMyself) {
           transactionCapsule.setVerified(true);
         }
         accountStateCallBack.preExeTrans();
         TransactionInfo result = processTransaction(transactionCapsule, block);
         accountStateCallBack.exeTransFinish();
         if (Objects.nonNull(result)) {
-          transactionRetCapsule.addTransactionInfo(result);
+          results.add(result);
         }
       }
+      transactionRetCapsule.addAllTransactionInfos(results);
       accountStateCallBack.executePushFinish();
     } finally {
       accountStateCallBack.exceptionFinish();