Skip to content

Commit 044c782

Browse files
viliehtejun
authored andcommitted
workqueue: fix checkpatch issues
Fixed some checkpatch warnings. tj: adapted to wq/for-3.7 and massaged pr_xxx() format strings a bit. Signed-off-by: Valentin Ilie <[email protected]> Signed-off-by: Tejun Heo <[email protected]> LKML-Reference: <[email protected]>
1 parent 7635d2f commit 044c782

File tree

1 file changed

+13
-16
lines changed

1 file changed

+13
-16
lines changed

kernel/workqueue.c

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -269,18 +269,18 @@ struct workqueue_struct {
269269
};
270270

271271
struct workqueue_struct *system_wq __read_mostly;
272-
struct workqueue_struct *system_highpri_wq __read_mostly;
273-
struct workqueue_struct *system_long_wq __read_mostly;
274-
struct workqueue_struct *system_nrt_wq __read_mostly;
275-
struct workqueue_struct *system_unbound_wq __read_mostly;
276-
struct workqueue_struct *system_freezable_wq __read_mostly;
277-
struct workqueue_struct *system_nrt_freezable_wq __read_mostly;
278272
EXPORT_SYMBOL_GPL(system_wq);
273+
struct workqueue_struct *system_highpri_wq __read_mostly;
279274
EXPORT_SYMBOL_GPL(system_highpri_wq);
275+
struct workqueue_struct *system_long_wq __read_mostly;
280276
EXPORT_SYMBOL_GPL(system_long_wq);
277+
struct workqueue_struct *system_nrt_wq __read_mostly;
281278
EXPORT_SYMBOL_GPL(system_nrt_wq);
279+
struct workqueue_struct *system_unbound_wq __read_mostly;
282280
EXPORT_SYMBOL_GPL(system_unbound_wq);
281+
struct workqueue_struct *system_freezable_wq __read_mostly;
283282
EXPORT_SYMBOL_GPL(system_freezable_wq);
283+
struct workqueue_struct *system_nrt_freezable_wq __read_mostly;
284284
EXPORT_SYMBOL_GPL(system_nrt_freezable_wq);
285285

286286
#define CREATE_TRACE_POINTS
@@ -2232,11 +2232,9 @@ __acquires(&gcwq->lock)
22322232
lock_map_release(&cwq->wq->lockdep_map);
22332233

22342234
if (unlikely(in_atomic() || lockdep_depth(current) > 0)) {
2235-
printk(KERN_ERR "BUG: workqueue leaked lock or atomic: "
2236-
"%s/0x%08x/%d\n",
2237-
current->comm, preempt_count(), task_pid_nr(current));
2238-
printk(KERN_ERR " last function: ");
2239-
print_symbol("%s\n", (unsigned long)f);
2235+
pr_err("BUG: workqueue leaked lock or atomic: %s/0x%08x/%d\n"
2236+
" last function: %pf\n",
2237+
current->comm, preempt_count(), task_pid_nr(current), f);
22402238
debug_show_held_locks(current);
22412239
dump_stack();
22422240
}
@@ -2790,8 +2788,8 @@ void drain_workqueue(struct workqueue_struct *wq)
27902788

27912789
if (++flush_cnt == 10 ||
27922790
(flush_cnt % 100 == 0 && flush_cnt <= 1000))
2793-
pr_warning("workqueue %s: flush on destruction isn't complete after %u tries\n",
2794-
wq->name, flush_cnt);
2791+
pr_warn("workqueue %s: flush on destruction isn't complete after %u tries\n",
2792+
wq->name, flush_cnt);
27952793
goto reflush;
27962794
}
27972795

@@ -3275,9 +3273,8 @@ static int wq_clamp_max_active(int max_active, unsigned int flags,
32753273
int lim = flags & WQ_UNBOUND ? WQ_UNBOUND_MAX_ACTIVE : WQ_MAX_ACTIVE;
32763274

32773275
if (max_active < 1 || max_active > lim)
3278-
printk(KERN_WARNING "workqueue: max_active %d requested for %s "
3279-
"is out of range, clamping between %d and %d\n",
3280-
max_active, name, 1, lim);
3276+
pr_warn("workqueue: max_active %d requested for %s is out of range, clamping between %d and %d\n",
3277+
max_active, name, 1, lim);
32813278

32823279
return clamp_val(max_active, 1, lim);
32833280
}

0 commit comments

Comments
 (0)