trace event only when category is enabled (#1814)

close #1813

Signed-off-by: ekexium <eke@fastmail.com>

Author: ekexium

txnkv/transaction/commit.go

@@ -103,12 +103,14 @@ func (action actionCommit) handleSingleBatch(c *twoPhaseCommitter, bo *retry.Bac
 		c.resourceGroupTagger(req)
 	}
 
-	trace.TraceEvent(bo.GetCtx(), trace.CategoryTxn2PC, "commit.batch.start",
-		zap.Uint64("startTS", c.startTS),
-		zap.Uint64("commitTS", c.commitTS),
-		zap.Uint64("regionID", batch.region.GetID()),
-		zap.Bool("isPrimary", batch.isPrimary),
-		zap.Int("keyCount", len(keys)))
+	if trace.IsCategoryEnabled(trace.CategoryTxn2PC) {
+		trace.TraceEvent(bo.GetCtx(), trace.CategoryTxn2PC, "commit.batch.start",
+			zap.Uint64("startTS", c.startTS),
+			zap.Uint64("commitTS", c.commitTS),
+			zap.Uint64("regionID", batch.region.GetID()),
+			zap.Bool("isPrimary", batch.isPrimary),
+			zap.Int("keyCount", len(keys)))
+	}
 
 	tBegin := time.Now()
 	attempts := 0
@@ -134,9 +136,11 @@ func (action actionCommit) handleSingleBatch(c *twoPhaseCommitter, bo *retry.Bac
 
 		// Unexpected error occurs, return it.
 		if err != nil {
-			trace.TraceEvent(bo.GetCtx(), trace.CategoryTxn2PC, "commit.batch.result",
-				zap.Uint64("regionID", batch.region.GetID()),
-				zap.Bool("success", false))
+			if trace.IsCategoryEnabled(trace.CategoryTxn2PC) {
+				trace.TraceEvent(bo.GetCtx(), trace.CategoryTxn2PC, "commit.batch.result",
+					zap.Uint64("regionID", batch.region.GetID()),
+					zap.Bool("success", false))
+			}
 			return err
 		}
 
@@ -256,9 +260,11 @@ func (action actionCommit) handleSingleBatch(c *twoPhaseCommitter, bo *retry.Bac
 	// Group that contains primary key is always the first.
 	// We mark transaction's status committed when we receive the first success response.
 	c.mu.committed = true
-	trace.TraceEvent(bo.GetCtx(), trace.CategoryTxn2PC, "commit.batch.result",
-		zap.Uint64("regionID", batch.region.GetID()),
-		zap.Bool("success", true))
+	if trace.IsCategoryEnabled(trace.CategoryTxn2PC) {
+		trace.TraceEvent(bo.GetCtx(), trace.CategoryTxn2PC, "commit.batch.result",
+			zap.Uint64("regionID", batch.region.GetID()),
+			zap.Bool("success", true))
+	}
 	return nil
 }
 

txnkv/transaction/prewrite.go

@@ -234,21 +234,25 @@ func (action actionPrewrite) handleSingleBatch(
 
 	handler := action.newSingleBatchPrewriteReqHandler(c, batch, bo)
 
-	trace.TraceEvent(bo.GetCtx(), trace.CategoryTxn2PC, "prewrite.batch.start",
-		zap.Uint64("startTS", c.startTS),
-		zap.Uint64("regionID", batch.region.GetID()),
-		zap.Bool("isPrimary", batch.isPrimary),
-		zap.Int("keyCount", batch.mutations.Len()))
+	if trace.IsCategoryEnabled(trace.CategoryTxn2PC) {
+		trace.TraceEvent(bo.GetCtx(), trace.CategoryTxn2PC, "prewrite.batch.start",
+			zap.Uint64("startTS", c.startTS),
+			zap.Uint64("regionID", batch.region.GetID()),
+			zap.Bool("isPrimary", batch.isPrimary),
+			zap.Int("keyCount", batch.mutations.Len()))
+	}
 
 	var retryable bool
 	for {
 		// It will return false if the request is success or meet an unretryable error.
 		// otherwise if the error is retryable, it will return true.
 		retryable, err = handler.sendReqAndCheck()
 		if !retryable {
-			trace.TraceEvent(bo.GetCtx(), trace.CategoryTxn2PC, "prewrite.batch.result",
-				zap.Uint64("regionID", batch.region.GetID()),
-				zap.Bool("success", err == nil))
+			if trace.IsCategoryEnabled(trace.CategoryTxn2PC) {
+				trace.TraceEvent(bo.GetCtx(), trace.CategoryTxn2PC, "prewrite.batch.result",
+					zap.Uint64("regionID", batch.region.GetID()),
+					zap.Bool("success", err == nil))
+			}
 			handler.drop(err)
 			return err
 		}

txnkv/txnlock/lock_resolver.go

@@ -498,11 +498,13 @@ func (lr *LockResolver) resolveLocks(bo *retry.Backoffer, opts ResolveLocksOptio
 			TTL: msBeforeTxnExpired.value(),
 		}, nil
 	}
-	trace.TraceEvent(bo.GetCtx(), trace.CategoryTxnLockResolve, "resolve_locks.start",
-		zap.Uint64("callerStartTS", callerStartTS),
-		zap.Int("lockCount", len(locks)),
-		zap.Bool("forRead", forRead),
-		zap.Bool("lite", lite))
+	if trace.IsCategoryEnabled(trace.CategoryTxnLockResolve) {
+		trace.TraceEvent(bo.GetCtx(), trace.CategoryTxnLockResolve, "resolve_locks.start",
+			zap.Uint64("callerStartTS", callerStartTS),
+			zap.Int("lockCount", len(locks)),
+			zap.Bool("forRead", forRead),
+			zap.Bool("lite", lite))
+	}
 
 	// trace the results
 	defer func() {