*: disable async commit

Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>

Author: lcwangchao

.github/workflows/integration.yml

@@ -2,9 +2,9 @@ name: Integration Test
 
 on:
   push:
-    branches: [ master, tidb-8.5 ]
+    branches: [ master, tidb-8.5, "feature/*" ]
   pull_request:
-    branches: [ master, tidb-8.5 ]
+    branches: [ master, tidb-8.5, "feature/*" ]
 
 jobs:
 

.github/workflows/test.yml

@@ -2,9 +2,9 @@ name: Unit Test
 
 on:
   push:
-    branches: [master, tidb-8.5]
+    branches: [master, tidb-8.5, "feature/*"]
   pull_request:
-    branches: [master, tidb-8.5]
+    branches: [master, tidb-8.5, "feature/*"]
 
 jobs:
   test:

integration_tests/2pc_test.go

@@ -2222,6 +2222,9 @@ func (s *testCommitterSuite) TestResolveMixed() {
 // TestSecondaryKeys tests that when async commit is enabled, each prewrite message includes an
 // accurate list of secondary keys.
 func (s *testCommitterSuite) TestPrewriteSecondaryKeys() {
+	transaction.DisableActiveActiveCommitSupportForTest()
+	defer transaction.RestoreActiveActiveCommitSupportForTest()
+
 	// Prepare two regions first: (, 100) and [100, )
 	region, _, _, _ := s.cluster.GetRegionByKey([]byte{50})
 	newRegionID := s.cluster.AllocID()
@@ -2256,6 +2259,9 @@ func (s *testCommitterSuite) TestPrewriteSecondaryKeys() {
 }
 
 func (s *testCommitterSuite) TestAsyncCommit() {
+	transaction.DisableActiveActiveCommitSupportForTest()
+	defer transaction.RestoreActiveActiveCommitSupportForTest()
+
 	ctx := context.Background()
 	pk := []byte("tpk")
 	pkVal := []byte("pkVal")
@@ -2344,6 +2350,9 @@ func restoreGlobalConfFunc() (restore func()) {
 }
 
 func (s *testCommitterSuite) TestAsyncCommitCheck() {
+	transaction.DisableActiveActiveCommitSupportForTest()
+	defer transaction.RestoreActiveActiveCommitSupportForTest()
+
 	defer restoreGlobalConfFunc()()
 	updateGlobalConfig(func(conf *config.Config) {
 		conf.TiKVClient.AsyncCommit.KeysLimit = 16

integration_tests/async_commit_test.go

@@ -87,6 +87,7 @@ func (c *unistoreClientWrapper) SendRequestAsync(ctx context.Context, addr strin
 func (c *unistoreClientWrapper) SetEventListener(listener tikv.ClientEventListener) {}
 
 func (s *testAsyncCommitCommon) setUpTest() {
+	transaction.DisableActiveActiveCommitSupportForTest()
 	if *withTiKV {
 		s.store = NewTestStore(s.T())
 		return
@@ -105,6 +106,7 @@ func (s *testAsyncCommitCommon) setUpTest() {
 
 func (s *testAsyncCommitCommon) tearDownTest() {
 	s.store.Close()
+	transaction.RestoreActiveActiveCommitSupportForTest()
 }
 
 func (s *testAsyncCommitCommon) putAlphabets(enableAsyncCommit bool) {

txnkv/transaction/2pc.go

@@ -92,6 +92,24 @@ var (
 	CommitMaxBackoff = uint64(40000)
 )
 
+// supportActiveActiveCommit indicates whether the active-active commit protocol is supported.
+// If it is true (by default), we should not use async-commit or 1PC to ensure the commit timestamp
+// should follow the `tso-unique-index` constraint.
+var supportActiveActiveCommit = atomicutil.NewBool(true)
+
+// DisableActiveActiveCommitSupportForTest disables the active-active commit for test,
+// which will make async-commit and 1PC work without the `tso-unique-index` constraint.
+// It should only be used in test.
+func DisableActiveActiveCommitSupportForTest() {
+	supportActiveActiveCommit.Store(false)
+}
+
+// RestoreActiveActiveCommitSupportForTest restores the default value of active-active commit support for test.
+// It should only be used in test.
+func RestoreActiveActiveCommitSupportForTest() {
+	supportActiveActiveCommit.Store(true)
+}
+
 type kvstore interface {
 	// GetRegionCache gets the RegionCache.
 	GetRegionCache() *locate.RegionCache
@@ -1504,6 +1522,10 @@ func sendTxnHeartBeat(
 
 // checkAsyncCommit checks if async commit protocol is available for current transaction commit, true is returned if possible.
 func (c *twoPhaseCommitter) checkAsyncCommit() bool {
+	if supportActiveActiveCommit.Load() {
+		return false
+	}
+
 	// Disable async commit in local transactions
 	if c.txn.GetScope() != oracle.GlobalTxnScope {
 		return false
@@ -1535,6 +1557,10 @@ func (c *twoPhaseCommitter) checkAsyncCommit() bool {
 
 // checkOnePC checks if 1PC protocol is available for current transaction.
 func (c *twoPhaseCommitter) checkOnePC() bool {
+	if supportActiveActiveCommit.Load() {
+		return false
+	}
+
 	// Disable 1PC in local transactions
 	if c.txn.GetScope() != oracle.GlobalTxnScope {
 		return false