*: disable async commit

Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>

Author: lcwangchao

.github/workflows/integration.yml

@@ -2,9 +2,9 @@ name: Integration Test
 
 on:
   push:
-    branches: [ master, tidb-8.5 ]
+    branches: [ master, tidb-8.5, "feature/*" ]
   pull_request:
-    branches: [ master, tidb-8.5 ]
+    branches: [ master, tidb-8.5, "feature/*" ]
 
 jobs:
 

.github/workflows/test.yml

@@ -2,9 +2,9 @@ name: Unit Test
 
 on:
   push:
-    branches: [master, tidb-8.5]
+    branches: [master, tidb-8.5, "feature/*"]
   pull_request:
-    branches: [master, tidb-8.5]
+    branches: [master, tidb-8.5, "feature/*"]
 
 jobs:
   test:

txnkv/transaction/2pc.go

@@ -92,6 +92,24 @@ var (
 	CommitMaxBackoff = uint64(40000)
 )
 
+// supportActiveActiveCommit indicates whether the active-active commit protocol is supported.
+// If it is true (by default), we should not use async-commit or 1PC to ensure the commit timestamp
+// should follow the `tso-unique-index` constraint.
+var supportActiveActiveCommit = atomicutil.NewBool(true)
+
+// DisableActiveActiveCommitSupportForTest disables the active-active commit for test,
+// which will make async-commit and 1PC work without the `tso-unique-index` constraint.
+// It should only be used in test.
+func DisableActiveActiveCommitSupportForTest() func() {
+	if !supportActiveActiveCommit.CompareAndSwap(true, false) {
+		return func() {}
+	}
+
+	return func() {
+		supportActiveActiveCommit.Store(true)
+	}
+}
+
 type kvstore interface {
 	// GetRegionCache gets the RegionCache.
 	GetRegionCache() *locate.RegionCache
@@ -1504,6 +1522,10 @@ func sendTxnHeartBeat(
 
 // checkAsyncCommit checks if async commit protocol is available for current transaction commit, true is returned if possible.
 func (c *twoPhaseCommitter) checkAsyncCommit() bool {
+	if supportActiveActiveCommit.Load() {
+		return false
+	}
+
 	// Disable async commit in local transactions
 	if c.txn.GetScope() != oracle.GlobalTxnScope {
 		return false
@@ -1535,6 +1557,10 @@ func (c *twoPhaseCommitter) checkAsyncCommit() bool {
 
 // checkOnePC checks if 1PC protocol is available for current transaction.
 func (c *twoPhaseCommitter) checkOnePC() bool {
+	if supportActiveActiveCommit.Load() {
+		return false
+	}
+
 	// Disable 1PC in local transactions
 	if c.txn.GetScope() != oracle.GlobalTxnScope {
 		return false