feat: .pixels return type changed to Uint8ClampedArray

Author: yisibl

CHANGELOG.md

@@ -220,7 +220,7 @@ In addition, resvg-js can return the raw pixels data of the PNG, which can be ve
 
 ### Added
 
-- feat: add `.pixels()` API for returning PNG pixels data ([#123](https://github.com/yisibl/resvg-js/pull/123)).
+- feat: add `.pixels` API for returning PNG pixels data ([#123](https://github.com/yisibl/resvg-js/pull/123)).
 - chore: upgrade to resvg v0.25.0 (by @zimond in [#156](https://github.com/yisibl/resvg-js/pull/156)).
   - Partial `paint-order` attribute support. Markers can only be under or above the shape.
   - CSS3 `writing-mode` variants `vertical-rl` and `vertical-lr`. Thanks to @yisibl.

Cargo.toml

@@ -9,7 +9,7 @@ version = "1.0.0"
 crate-type = ["cdylib"]
 
 [dependencies]
-env_logger = "0.10.0"
+env_logger = "0.11.2"
 log = "0.4"
 
 serde = { version = "1", features = ["derive"] }
@@ -35,8 +35,8 @@ resvg = { version = "0.34.0", default-features = false, features = [
 ] }
 
 [target.'cfg(not(target_arch = "wasm32"))'.dependencies]
-napi = { version = "2.13.3", features = ["serde-json", "async"] }
-napi-derive = "2.13.0"
+napi = { version = "2.16.0", features = ["serde-json", "async"] }
+napi-derive = "2.16.0"
 resvg = { version = "0.34.0", default-features = false, features = [
     "raster-images",
     "text",

__test__/index.spec.ts

@@ -9,7 +9,7 @@ import { Resvg, renderAsync } from '../index'
 
 import { jimpToRgbaPixels } from './helper'
 
-test('Use href to load a JPG image without alpha', async (t) => {
+test.skip('Use href to load a JPG image without alpha', async (t) => {
   const imgUrl = 'https://wd.imgix.net/image/kheDArv5csY6rvQUJDbWRscckLr1/De5peVXJZz3uSEmmVeYJ.png?w=500'
   const svg = `<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
   <image href="${imgUrl}" width="500" height="250"/>
@@ -79,7 +79,7 @@ test('svg to RGBA pixels Array', async (t) => {
   const pngData = resvg.render()
   const pngBuffer = pngData.asPng()
 
-  const originPixels = pngData.pixels.toJSON().data
+  const originPixels = pngData.pixels
   const pixelArray = await jimpToRgbaPixels(pngBuffer, pngData.width, pngData.height)
 
   t.is(originPixels.length, pixelArray.length)
@@ -258,7 +258,7 @@ test('should be load custom fontFiles(no defaultFontFamily option)', (t) => {
     logLevel: 'debug',
   })
   const pngData = resvg.render()
-  const originPixels = pngData.pixels.toJSON().data
+  const originPixels = pngData.pixels
 
   // Find the number of blue `rgb(0,255,255)`pixels
   t.is(originPixels.join(',').match(/0,0,255/g)?.length, 1727)
@@ -280,7 +280,7 @@ test('should be load custom fontDirs(no defaultFontFamily option)', (t) => {
     },
   })
   const pngData = resvg.render()
-  const originPixels = pngData.pixels.toJSON().data
+  const originPixels = pngData.pixels
 
   // Find the number of blue `rgb(0,255,255)`pixels
   t.is(originPixels.join(',').match(/0,0,255/g)?.length, 1727)
@@ -303,7 +303,7 @@ test('The defaultFontFamily is not found in the OS and needs to be fallback', (t
     logLevel: 'debug',
   })
   const pngData = resvg.render()
-  const originPixels = pngData.pixels.toJSON().data
+  const originPixels = pngData.pixels
   // Find the number of blue `rgb(0,255,255)`pixels
   const matchPixels = originPixels.join(',').match(/0,0,255/g)
   t.true(matchPixels !== null) // If the font is not matched, there are no blue pixels.
@@ -327,7 +327,7 @@ test('Test defaultFontFamily', (t) => {
     logLevel: 'debug',
   })
   const pngData = resvg.render()
-  const originPixels = pngData.pixels.toJSON().data
+  const originPixels = pngData.pixels
   // Find the number of blue `rgb(0,255,255)`pixels
   const matchPixels = originPixels.join(',').match(/0,0,255/g)
   t.true(matchPixels !== null) // If the font is not matched, there are no blue pixels.

__test__/wasm.spec.ts

@@ -15,7 +15,7 @@ test.before(async () => {
   await initWasm(fs.readFile(join(__dirname, '../wasm/index_bg.wasm')))
 })
 
-test('Use href to load a JPG image without alpha', async (t) => {
+test.skip('Use href to load a JPG image without alpha', async (t) => {
   const imgUrl = 'https://wd.imgix.net/image/kheDArv5csY6rvQUJDbWRscckLr1/De5peVXJZz3uSEmmVeYJ.png?w=500'
   const svg = `<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
   <image href="${imgUrl}" width="500" height="250"/>
@@ -62,7 +62,7 @@ test('svg to RGBA pixels Array', async (t) => {
   const pngData = resvg.render()
   const pngBuffer = pngData.asPng()
 
-  const originPixels = Array.from(pngData.pixels)
+  const originPixels = pngData.pixels
   const pixelArray = await jimpToRgbaPixels(Buffer.from(pngBuffer), pngData.width, pngData.height)
 
   t.is(originPixels.length, pixelArray.length)

index.d.ts

@@ -84,15 +84,15 @@ export class Resvg {
   get height(): number
 }
 export class RenderedImage {
-  /** Write the image data to Buffer */
-  asPng(): Buffer
-
-  /** Get the RGBA pixels of the image */
-  get pixels(): Buffer
-
   /** Get the PNG width */
-  get width(): number
+  readonly width: number
 
   /** Get the PNG height */
-  get height(): number
+  readonly height: number
+
+  /** Get the RGBA pixels of the image */
+  readonly pixels: Uint8ClampedArray
+
+  /** Write the image data to Buffer */
+  asPng(): Buffer
 }

js-binding.d.ts

@@ -44,7 +44,7 @@ export class RenderedImage {
   /** Write the image data to Buffer */
   asPng(): Buffer
   /** Get the RGBA pixels of the image */
-  get pixels(): Buffer
+  get pixels(): Uint8ClampedArray
   /** Get the PNG width */
   get width(): number
   /** Get the PNG height */

js-binding.js

@@ -237,6 +237,49 @@ switch (platform) {
           loadError = e
         }
         break
+      case 'riscv64':
+        if (isMusl()) {
+          localFileExisted = existsSync(
+            join(__dirname, 'resvgjs.linux-riscv64-musl.node')
+          )
+          try {
+            if (localFileExisted) {
+              nativeBinding = require('./resvgjs.linux-riscv64-musl.node')
+            } else {
+              nativeBinding = require('@resvg/resvg-js-linux-riscv64-musl')
+            }
+          } catch (e) {
+            loadError = e
+          }
+        } else {
+          localFileExisted = existsSync(
+            join(__dirname, 'resvgjs.linux-riscv64-gnu.node')
+          )
+          try {
+            if (localFileExisted) {
+              nativeBinding = require('./resvgjs.linux-riscv64-gnu.node')
+            } else {
+              nativeBinding = require('@resvg/resvg-js-linux-riscv64-gnu')
+            }
+          } catch (e) {
+            loadError = e
+          }
+        }
+        break
+      case 's390x':
+        localFileExisted = existsSync(
+          join(__dirname, 'resvgjs.linux-s390x-gnu.node')
+        )
+        try {
+          if (localFileExisted) {
+            nativeBinding = require('./resvgjs.linux-s390x-gnu.node')
+          } else {
+            nativeBinding = require('@resvg/resvg-js-linux-s390x-gnu')
+          }
+        } catch (e) {
+          loadError = e
+        }
+        break
       default:
         throw new Error(`Unsupported architecture on Linux: ${arch}`)
     }

package.json

@@ -73,7 +73,7 @@
     "version": "napi version"
   },
   "devDependencies": {
-    "@napi-rs/cli": "^2.16.3",
+    "@napi-rs/cli": "2.18.0",
     "@swc-node/register": "1.6.4",
     "@swc/core": "^1.3.88",
     "@types/node": "^20.6.5",

src/lib.rs

@@ -6,7 +6,7 @@ use std::sync::Arc;
 
 #[cfg(not(target_arch = "wasm32"))]
 use napi::bindgen_prelude::{
-    AbortSignal, AsyncTask, Buffer, Either, Error as NapiError, Task, Undefined,
+    AbortSignal, AsyncTask, Buffer, Uint8ClampedArray, Either, Error as NapiError, Task, Undefined,
 };
 #[cfg(not(target_arch = "wasm32"))]
 use napi_derive::napi;
@@ -111,15 +111,15 @@ impl RenderedImage {
     /// Get the RGBA pixels of the image
     #[cfg(target_arch = "wasm32")]
     #[wasm_bindgen(getter)]
-    pub fn pixels(&self) -> js_sys::Uint8Array {
+    pub fn pixels(&self) -> js_sys::Uint8ClampedArray {
         self.pix.data().into()
     }
 
     /// Get the RGBA pixels of the image
     #[cfg(not(target_arch = "wasm32"))]
     #[napi(getter)]
-    pub fn pixels(&self) -> Buffer {
-        self.pix.data().into()
+    pub fn pixels(&self) -> Uint8ClampedArray {
+        Uint8ClampedArray::new(self.pix.data().into())
     }
 
     #[cfg(not(target_arch = "wasm32"))]

wasm/index.d.ts

@@ -29,7 +29,7 @@ declare class RenderedImage {
 	/**
 	* Get the RGBA pixels of the image
 	*/
-	readonly pixels: Uint8Array;
+	readonly pixels: Uint8ClampedArray;
 	/**
 	* Get the PNG width
 	*/