Skip to content

Update metadata version comparison rules in client workflow #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions tuf-spec.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Title: The Update Framework Specification
Shortname: TUF
Status: LS
Abstract: A framework for securing software update systems.
Date: 2022-04-08
Date: 2022-04-28
Editor: Justin Cappos, NYU
Editor: Trishank Karthik Kuppusamy, Datadog
Editor: Joshua Lock, VMware
Expand All @@ -16,7 +16,7 @@ Boilerplate: copyright no, conformance no
Local Boilerplate: header yes
Markup Shorthands: css no, markdown yes
Metadata Include: This version off, Abstract off
Text Macro: VERSION 1.0.29
Text Macro: VERSION 1.0.30
</pre>

Note: We strive to make the specification easy to implement, so if you come
Expand Down Expand Up @@ -1315,12 +1315,13 @@ it in the next step.
and report the signature failure.

5. **Check for a rollback attack.** The version number of the trusted
root metadata file (version N) MUST be less than or equal to the version
root metadata file (version N) MUST be less than the version
number of the new root metadata file (version N+1). Effectively, this means
checking that the version number signed in the new root metadata file is
indeed N+1. If the version of the new root metadata file is less than the
trusted metadata file, discard it, abort the update cycle, and report the
rollback attack.
indeed N+1. If the version of the new root metadata file is less than the version
of the trusted metadata file, discard it, abort the update cycle, and report the
rollback attack. In case they are equal, again discard the new root metadata, but
proceed the update cycle with the already trusted root metadata.

6. Note that the expiration of the new (intermediate) root metadata
file does not matter yet, because we will check for it in step 5.3.10.
Expand Down Expand Up @@ -1361,21 +1362,25 @@ it in the next step.

2. **Check for an arbitrary software attack.** The new timestamp
metadata file MUST have been signed by a threshold of keys specified in the
trusted root metadata file. If the new timestamp metadata file is not
trusted root metadata file. If the new timestamp metadata file is not
properly signed, discard it, abort the update cycle, and report the signature
failure.

3. **Check for a rollback attack.**

1. The version number of the trusted timestamp metadata file, if
any, MUST be less than or equal to the version number of the new timestamp
metadata file. If the new timestamp metadata file is older than the
trusted timestamp metadata file, discard it, abort the update cycle, and
report the potential rollback attack.
any, MUST be less than the version number of the new timestamp
metadata file. If the new timestamp metadata version is less than the trusted
timestamp metadata version, discard it, abort the update cycle, and
report the potential rollback attack. In case they are equal, discard the new
timestamp metadata and abort the update cycle. This is normal and it
shouldn't raise any error. The reason for aborting the update process is that
there shouldn't be any changes in the content of this, or any other metadata
files too, considering it has the same version as the already trusted one.

2. The version number of the snapshot metadata file in the
trusted timestamp metadata file, if any, MUST be less than or equal to its
version number in the new timestamp metadata file. If not, discard the new
version number in the new timestamp metadata file. If not, discard the new
timestamp metadata file, abort the update cycle, and report the failure.

4. **Check for a freeze attack.** The expiration timestamp in the
Expand Down