Merge pull request #23 from RobvH/improve-reference-payment

Use CardReference for reference purchases

Author: delatbabel

src/Message/AuthorizeRequest.php

@@ -261,8 +261,10 @@ public function getData()
         $data['ORDERID'] = $this->getOrderId();
         $data['PONUM'] = $this->getPoNum();
 
-        $data['BILLTOEMAIL'] = $this->getCard()->getEmail();
-        $data['BILLTOPHONENUM'] = $this->getCard()->getBillingPhone();
+        if ($this->getCard()) {
+            $data['BILLTOEMAIL'] = $this->getCard()->getEmail();
+            $data['BILLTOPHONENUM'] = $this->getCard()->getBillingPhone();
+        }
 
         $items = $this->getItems();
         if (!empty($items)) {

src/Message/PurchaseRequest.php

@@ -36,8 +36,8 @@
  * // $reference_id can be the transaction reference from a previous authorization, credit, capture, sale, voice auth,
  * // or void.
  * $transaction = $gateway->purchase(array(
- *     'amount'                   => '10.00',
- *     'transactionReference'     => $reference_id,
+ *     'amount'        => '10.00',
+ *     'cardReference' => $reference_id,
  * ));
  *
  * // 2. Sale (with card data) example:
@@ -69,25 +69,4 @@
 class PurchaseRequest extends AuthorizeRequest
 {
     protected $action = 'S';
-
-    public function getData()
-    {
-        if ($this->parameters->get('transactionReference')) {
-            return $this->getReferenceSaleData();
-        }
-
-        return parent::getData();
-    }
-
-    public function getReferenceSaleData()
-    {
-        $this->validate('transactionReference', 'amount');
-
-        $data = $this->getBaseData();
-        $data['AMT'] = $this->getAmount();
-        $data['ORIGID'] = $this->getTransactionReference();
-        $data['TENDER'] = 'C';
-
-        return $data;
-    }
 }

tests/ProGatewayTest.php

@@ -75,7 +75,7 @@ public function testReferencePurchaseSuccess()
     {
         $options = array(
             'amount' => '10.00',
-            'transactionReference' => 'abc123',
+            'cardReference' => 'abc123',
         );
 
         $this->setMockHttpResponse('PurchaseSuccess.txt');