Skip to content

Commit e4941a5

Browse files
authored
Clarify new bucket store metrics (#3229)
* Clarify new bucket store metrics Signed-off-by: Marco Pracucci <marco@pracucci.com> * Improved metrics help message based on feedback received Signed-off-by: Marco Pracucci <marco@pracucci.com>
1 parent 830ac35 commit e4941a5

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pkg/store/bucket.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -226,13 +226,13 @@ func newBucketStoreMetrics(reg prometheus.Registerer) *bucketStoreMetrics {
226226

227227
m.seriesFetchDuration = promauto.With(reg).NewHistogram(prometheus.HistogramOpts{
228228
Name: "thanos_bucket_store_cached_series_fetch_duration_seconds",
229-
Help: "Time it takes to fetch series from a bucket to respond a query. It also includes the time it takes to cache fetch and store operations.",
229+
Help: "The time it takes to fetch series to respond to a request sent to a store gateway. It includes both the time to fetch it from the cache and from storage in case of cache misses.",
230230
Buckets: []float64{0.001, 0.01, 0.1, 0.3, 0.6, 1, 3, 6, 9, 20, 30, 60, 90, 120},
231231
})
232232

233233
m.postingsFetchDuration = promauto.With(reg).NewHistogram(prometheus.HistogramOpts{
234234
Name: "thanos_bucket_store_cached_postings_fetch_duration_seconds",
235-
Help: "Time it takes to fetch postings from a bucket to respond a query. It also includes the time it takes to cache fetch and store operations.",
235+
Help: "The time it takes to fetch postings to respond to a request sent to a store gateway. It includes both the time to fetch it from the cache and from storage in case of cache misses.",
236236
Buckets: []float64{0.001, 0.01, 0.1, 0.3, 0.6, 1, 3, 6, 9, 20, 30, 60, 90, 120},
237237
})
238238

0 commit comments

Comments
 (0)