fix: executing queries without chromedriver #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohaibbq
changed the title
WebElements are properly transformed
|
Hi there 👋 Thanks for raising this! You are absolutely right this is broken when not using the chromedriver service, I guess Chromedriver is able to process the untransformed elements by happy accident? I'm not sure either 🤷♂️. The changes make sense to me and as you say this is how WebdriverIO expects arguments to be passed to executeAsync so this will likely prevent unexpected behaviour in future. 🙌 Once the branch has passed it's tests I'll squash and merge with a |
olivierwilkinson
changed the title
WebElements are properly transformed
|
🎉 This PR is included in version 2.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test suite on
mastercurrently fails if you remove theservices: ['chromedriver']fromwdio.conf.js.executeAsyncexpects args to be passed in position order. It captures them using the rest operator (...args).The list of arguments is then passed to
executeScriptAsyncwhich transforms them.The transformer checks the for the presence of the WebElement identifier. If it exists, it will transform it into a Puppeteer element handle. However, since the
argis a 2 dimensional array, it does not perform the transformation, as the WebElement identifier property does not exist.As for why this works in Chromedriver.. 🤷