Skip to content

Meemaw/typescript 4.0.2 #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2020
Merged

Meemaw/typescript 4.0.2 #248

merged 2 commits into from
Sep 13, 2020

Conversation

Meemaw
Copy link
Contributor

@Meemaw Meemaw commented Sep 13, 2020 •
edited
Loading

  • Make typings a bit safer (remove @ts-ignore)
  • Fix wrong union type in "within" function

@Meemaw Meemaw mentioned this pull request Sep 13, 2020
Closed
@benmonro
Copy link
Member

Excellent thank you @Meemaw !

@benmonro benmonro merged commit f9bae3f into testing-library:master Sep 13, 2020
@github-actions
Copy link

🎉 This PR is included in version 4.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Meemaw @benmonro