Skip to content

Commit f1f79dc

Browse files
authored
Fix regression using GenericContainer#setImage (#7820)
1dba8d1 introduced a breaking change. `GenericContainer#getImage` returns the value of `ContainerDef#getImage` instead of `RemoteImageName` because this is not set anymore when using `GenericContainer#setImage`. Fixes #7819
1 parent b59888a commit f1f79dc

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

core/src/main/java/org/testcontainers/containers/GenericContainer.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -267,6 +267,7 @@ public GenericContainer(@NonNull final Future<String> image) {
267267
}
268268

269269
public void setImage(Future<String> image) {
270+
this.image = new RemoteDockerImage(image);
270271
this.containerDef.setImage(new RemoteDockerImage(image));
271272
}
272273

core/src/test/java/org/testcontainers/containers/GenericContainerTest.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import org.testcontainers.TestImages;
2121
import org.testcontainers.containers.startupcheck.StartupCheckStrategy;
2222
import org.testcontainers.containers.wait.strategy.AbstractWaitStrategy;
23+
import org.testcontainers.images.RemoteDockerImage;
2324
import org.testcontainers.images.builder.ImageFromDockerfile;
2425
import org.testcontainers.images.builder.Transferable;
2526
import org.testcontainers.utility.MountableFile;
@@ -222,6 +223,14 @@ public void testArchitectureCheck() {
222223
}
223224
}
224225

226+
@Test
227+
public void shouldReturnTheProvidedImage() {
228+
GenericContainer container = new GenericContainer(TestImages.REDIS_IMAGE);
229+
assertThat(container.getImage().get()).isEqualTo("redis:3.0.2");
230+
container.setImage(new RemoteDockerImage(TestImages.ALPINE_IMAGE));
231+
assertThat(container.getImage().get()).isEqualTo("alpine:3.16");
232+
}
233+
225234
static class NoopStartupCheckStrategy extends StartupCheckStrategy {
226235

227236
@Override

0 commit comments

Comments
 (0)