Skip to content

Commit ece9945

Browse files
author
lizhou1111
committed
fix comments
1 parent b54976c commit ece9945

File tree

6 files changed

+16
-22
lines changed

6 files changed

+16
-22
lines changed

modules/timeplus/src/main/java/org/testcontainers/containers/TimeplusContainer.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,9 @@ public class TimeplusContainer extends JdbcDatabaseContainer<TimeplusContainer>
1515

1616
public static final String NAME = "timeplus";
1717

18-
private static final DockerImageName DEFAULT_IMAGE_NAME = DockerImageName.parse(
19-
"ghcr.io/timeplus-io/proton:latest"
20-
);
18+
private static final DockerImageName DEFAULT_IMAGE_NAME = DockerImageName.parse("timeplus/timeplusd:2.2.10");
2119

22-
private static final DockerImageName TIMEPLUS_IMAGE_NAME = DockerImageName.parse(
23-
"ghcr.io/timeplus-io/proton:latest"
24-
);
20+
private static final DockerImageName TIMEPLUS_IMAGE_NAME = DockerImageName.parse("timeplus/timeplusd:2.3.3");
2521

2622
@Deprecated
2723
public static final String IMAGE = DEFAULT_IMAGE_NAME.getUnversionedPart();

modules/timeplus/src/main/java/org/testcontainers/timeplus/TimeplusContainer.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,7 @@ public class TimeplusContainer extends JdbcDatabaseContainer<TimeplusContainer>
1515

1616
private static final String NAME = "timeplus";
1717

18-
private static final DockerImageName TIMEPLUS_IMAGE_NAME = DockerImageName.parse(
19-
"ghcr.io/timeplus-io/proton:latest"
20-
);
18+
private static final DockerImageName TIMEPLUS_IMAGE_NAME = DockerImageName.parse("timeplus/timeplusd:2.3.3");
2119

2220
private static final Integer HTTP_PORT = 3128;
2321

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
package org.testcontainers;
2+
3+
import org.testcontainers.utility.DockerImageName;
4+
5+
public interface TimeplusImages {
6+
DockerImageName TIMEPLUS_PROTON_IMAGE = DockerImageName.parse("timeplus/timeplusd:2.2.10");
7+
DockerImageName TIMEPLUS_IMAGE = DockerImageName.parse("timeplus/timeplusd:2.3.3");
8+
}

modules/timeplus/src/test/java/org/testcontainers/TimeplusTestImages.java

Lines changed: 0 additions & 8 deletions
This file was deleted.

modules/timeplus/src/test/java/org/testcontainers/junit/clickhouse/SimpleTimeplusTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import org.junit.Test;
44
import org.junit.runner.RunWith;
55
import org.junit.runners.Parameterized;
6-
import org.testcontainers.TimeplusTestImages;
6+
import org.testcontainers.TimeplusImages;
77
import org.testcontainers.containers.TimeplusContainer;
88
import org.testcontainers.db.AbstractContainerDatabaseTest;
99
import org.testcontainers.utility.DockerImageName;
@@ -25,8 +25,8 @@ public SimpleTimeplusTest(DockerImageName imageName) {
2525
@Parameterized.Parameters(name = "{0}")
2626
public static Object[][] data() {
2727
return new Object[][] { //
28-
{ TimeplusTestImages.TIMEPLUS_PROTON_IMAGE },
29-
{ TimeplusTestImages.TIMEPLUS_IMAGE },
28+
{ TimeplusImages.TIMEPLUS_PROTON_IMAGE },
29+
{ TimeplusImages.TIMEPLUS_IMAGE },
3030
};
3131
}
3232

modules/timeplus/src/test/java/org/testcontainers/timeplus/TimeplusContainerTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public class TimeplusContainerTest extends AbstractContainerDatabaseTest {
1212

1313
@Test
1414
public void testSimple() throws SQLException {
15-
try (TimeplusContainer timeplus = new TimeplusContainer("ghcr.io/timeplus-io/proton:latest")) {
15+
try (TimeplusContainer timeplus = new TimeplusContainer("timeplus/timeplusd:2.3.3")) {
1616
timeplus.start();
1717

1818
ResultSet resultSet = performQuery(timeplus, "SELECT 1");
@@ -25,7 +25,7 @@ public void testSimple() throws SQLException {
2525
@Test
2626
public void customCredentialsWithUrlParams() throws SQLException {
2727
try (
28-
TimeplusContainer timeplus = new TimeplusContainer("ghcr.io/timeplus-io/proton:latest")
28+
TimeplusContainer timeplus = new TimeplusContainer("timeplus/timeplusd:2.3.3")
2929
.withUsername("test")
3030
.withPassword("test")
3131
.withDatabaseName("test")

0 commit comments

Comments
 (0)