Skip to content

Commit 858b0ca

Browse files
committed
fix several problems
1 parent 69a6974 commit 858b0ca

File tree

6 files changed

+13
-16
lines changed

6 files changed

+13
-16
lines changed

docs/modules/databases/jdbc.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ Insert `tc:` after `jdbc:` as follows. Note that the hostname, port and database
8989

9090
#### Using Timeplus
9191

92-
`jdbc:tc:timeplus:2.3.3:///databasename`
92+
`jdbc:tc:timeplus:2.3.21:///databasename`
9393

9494
#### Using Trino
9595

mkdocs.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ nav:
7272
- modules/databases/presto.md
7373
- modules/databases/questdb.md
7474
- modules/databases/tidb.md
75+
- modules/databases/timeplus.md
7576
- modules/databases/trino.md
7677
- modules/databases/yugabytedb.md
7778
- modules/activemq.md

modules/timeplus/src/main/java/org/testcontainers/timeplus/TimeplusContainerProvider.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
*/
1010
public class TimeplusContainerProvider extends JdbcDatabaseContainerProvider {
1111

12-
private static final String DEFAULT_TAG = "2.3.3";
12+
private static final String DEFAULT_TAG = "2.3.21";
1313

1414
@Override
1515
public boolean supports(String databaseType) {

modules/timeplus/src/test/java/org/testcontainers/TimeplusImages.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
import org.testcontainers.utility.DockerImageName;
44

55
public interface TimeplusImages {
6-
DockerImageName TIMEPLUS_IMAGE = DockerImageName.parse("timeplus/timeplusd:2.3.3");
6+
DockerImageName TIMEPLUS_IMAGE = DockerImageName.parse("timeplus/timeplusd:2.3.21");
77
}

modules/timeplus/src/test/java/org/testcontainers/junit/timeplus/SimpleTimeplusTest.java

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
import org.junit.Test;
44
import org.testcontainers.TimeplusImages;
5+
import org.testcontainers.containers.JdbcDatabaseContainer;
56
import org.testcontainers.db.AbstractContainerDatabaseTest;
6-
import org.testcontainers.timeplus.TimeplusContainer;
7-
import org.testcontainers.utility.DockerImageName;
7+
import org.testcontainers.timeplus.TimeplusContainerProvider;
88

99
import java.sql.ResultSet;
1010
import java.sql.SQLException;
@@ -13,19 +13,13 @@
1313

1414
public class SimpleTimeplusTest extends AbstractContainerDatabaseTest {
1515

16-
private final DockerImageName imageName;
17-
18-
public SimpleTimeplusTest(DockerImageName imageName) {
19-
this.imageName = imageName;
20-
}
21-
2216
public static Object[][] data() {
2317
return new Object[][] { { TimeplusImages.TIMEPLUS_IMAGE } };
2418
}
2519

2620
@Test
2721
public void testSimple() throws SQLException {
28-
try (TimeplusContainer timeplus = new TimeplusContainer(this.imageName)) {
22+
try (JdbcDatabaseContainer timeplus = new TimeplusContainerProvider().newInstance()) {
2923
timeplus.start();
3024

3125
ResultSet resultSet = performQuery(timeplus, "SELECT 1");

modules/timeplus/src/test/java/org/testcontainers/timeplus/TimeplusContainerTest.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package org.testcontainers.timeplus;
22

33
import org.junit.Test;
4+
import org.testcontainers.containers.JdbcDatabaseContainer;
45
import org.testcontainers.db.AbstractContainerDatabaseTest;
56

67
import java.sql.ResultSet;
@@ -12,7 +13,7 @@ public class TimeplusContainerTest extends AbstractContainerDatabaseTest {
1213

1314
@Test
1415
public void testSimple() throws SQLException {
15-
try (TimeplusContainer timeplus = new TimeplusContainer("timeplus/timeplusd:2.3.3")) {
16+
try (JdbcDatabaseContainer timeplus = new TimeplusContainerProvider().newInstance()) {
1617
timeplus.start();
1718

1819
ResultSet resultSet = performQuery(timeplus, "SELECT 1");
@@ -25,17 +26,18 @@ public void testSimple() throws SQLException {
2526
@Test
2627
public void customCredentialsWithUrlParams() throws SQLException {
2728
try (
28-
TimeplusContainer timeplus = new TimeplusContainer("timeplus/timeplusd:2.3.3")
29+
JdbcDatabaseContainer timeplus = new TimeplusContainerProvider()
30+
.newInstance()
2931
.withUsername("system")
3032
.withPassword("sys@t+")
3133
.withDatabaseName("system")
32-
.withUrlParam("max_result_rows", "5")
34+
.withUrlParam("interactive_delay", "5")
3335
) {
3436
timeplus.start();
3537

3638
ResultSet resultSet = performQuery(
3739
timeplus,
38-
"SELECT value FROM system.settings where name='max_result_rows'"
40+
"SELECT to_int(value) FROM system.settings where name='interactive_delay'"
3941
);
4042

4143
int resultSetInt = resultSet.getInt(1);

0 commit comments

Comments
 (0)