Skip to content

Commit df105fd

Browse files
committed
address feedback
1 parent 3c9ba8f commit df105fd

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

tensorflow_io/arrow/python/kernel_tests/arrow_test.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -98,9 +98,7 @@ def run_test_case(self, dataset, case_data):
9898
next_element = iterator.get_next()
9999

100100
def is_float(dtype):
101-
return dtype == dtypes.float16 or \
102-
dtype == dtypes.float32 or \
103-
dtype == dtypes.float64
101+
return dtype in [dtypes.float16, dtypes.float32, dtypes.float64]
104102

105103
with self.test_session() as sess:
106104
for row in range(len(case_data.data[0])):
@@ -200,9 +198,9 @@ def testArrowFeatherDataset(self):
200198
batch = self.make_record_batch(test_data)
201199
df = batch.to_pandas()
202200

203-
f = tempfile.NamedTemporaryFile(delete=False)
204-
write_feather(df, f)
205-
f.close()
201+
# Create a tempfile that is deleted after tests run
202+
with tempfile.NamedTemporaryFile(delete=False) as f:
203+
write_feather(df, f)
206204

207205
# test single file
208206
dataset = arrow_dataset_ops.ArrowFeatherDataset(

0 commit comments

Comments
 (0)