Defined a bazel rule of cc_import_library to only accepts system library

and use `cc_import_library` rule to prevent including GPL code.

Signed-off-by: Yong Tang <[email protected]>

Author: yongtang

WORKSPACE

@@ -1,3 +1,5 @@
+workspace(name = "org_tensorflow")
+
 load("//tf:tf_configure.bzl", "tf_configure")
 load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 

third_party/ffmpeg_2_8.BUILD

@@ -5,10 +5,10 @@ licenses(["notice"])  # LGPL v2.1+ license
 
 exports_files(["LICENSE.md"])
 
-cc_library(
+load("@org_tensorflow//third_party:repo.bzl", "cc_import_library")
+
+cc_import_library(
     name = "ffmpeg",
-    srcs = [
-    ],
     hdrs = [
         "libavformat/avformat.h",
         "libavformat/avio.h",
@@ -41,53 +41,14 @@ cc_library(
         "libswscale/swscale.h",
         "libswscale/version.h",
     ],
-    copts = [],
-    defines = [],
-    includes = [],
-    linkopts = [
-        "-L$(GENDIR)/external/ffmpeg_2_8",
-        "-l:libavformat-ffmpeg.so.56",
-        "-l:libavcodec-ffmpeg.so.56",
-        "-l:libavutil-ffmpeg.so.54",
-        "-l:libswscale-ffmpeg.so.3",
-    ],
-    visibility = ["//visibility:public"],
-    deps = [],
-    data = [
+    libraries = [
         "libavformat-ffmpeg.so.56",
         "libavcodec-ffmpeg.so.56",
         "libavutil-ffmpeg.so.54",
         "libswscale-ffmpeg.so.3",
     ],
 )
 
-# Stab library files for build to be successful
-# even when those files are not installed (e.g., Ubuntu 14.04)
-# In runtime (e.g., Ubuntu 18.04) system files will be used.
-genrule(
-    name = "libavformat-ffmpeg_so_56",
-    outs = ["libavformat-ffmpeg.so.56"],
-    cmd = "echo '' | g++ -shared -fPIC -x c++ - -o $@",
-)
-
-genrule(
-    name = "libavcodec-ffmpeg_so_56",
-    outs = ["libavcodec-ffmpeg.so.56"],
-    cmd = "echo '' | g++ -shared -fPIC -x c++ - -o $@",
-)
-
-genrule(
-    name = "libavutil-ffmpeg_so_54",
-    outs = ["libavutil-ffmpeg.so.54"],
-    cmd = "echo '' | g++ -shared -fPIC -x c++ - -o $@",
-)
-
-genrule(
-    name = "libswscale-ffmpeg_so_3",
-    outs = ["libswscale-ffmpeg.so.3"],
-    cmd = "echo '' | g++ -shared -fPIC -x c++ - -o $@",
-)
-
 genrule(
     name = "libavutil_avconfig_h",
     outs = ["libavutil/avconfig.h"],

third_party/ffmpeg_3_4.BUILD

@@ -5,10 +5,10 @@ licenses(["notice"])  # LGPL v2.1+ license
 
 exports_files(["LICENSE.md"])
 
-cc_library(
+load("@org_tensorflow//third_party:repo.bzl", "cc_import_library")
+
+cc_import_library(
     name = "ffmpeg",
-    srcs = [
-    ],
     hdrs = [
         "libavformat/avformat.h",
         "libavformat/avio.h",
@@ -39,53 +39,14 @@ cc_library(
         "libswscale/swscale.h",
         "libswscale/version.h",
     ],
-    copts = [],
-    defines = [],
-    includes = [],
-    linkopts = [
-        "-L$(GENDIR)/external/ffmpeg_3_4",
-        "-l:libavformat.so.57",
-        "-l:libavcodec.so.57",
-        "-l:libavutil.so.55",
-        "-l:libswscale.so.4",
-    ],
-    visibility = ["//visibility:public"],
-    deps = [],
-    data = [
+    libraries = [
         "libavformat.so.57",
         "libavcodec.so.57",
         "libavutil.so.55",
         "libswscale.so.4",
     ],
 )
 
-# Stab library files for build to be successful
-# even when those files are not installed (e.g., Ubuntu 14.04)
-# In runtime (e.g., Ubuntu 18.04) system files will be used.
-genrule(
-    name = "libavformat_so_57",
-    outs = ["libavformat.so.57"],
-    cmd = "echo '' | g++ -shared -fPIC -x c++ - -o $@",
-)
-
-genrule(
-    name = "libavcodec_so_57",
-    outs = ["libavcodec.so.57"],
-    cmd = "echo '' | g++ -shared -fPIC -x c++ - -o $@",
-)
-
-genrule(
-    name = "libavutil_so_55",
-    outs = ["libavutil.so.55"],
-    cmd = "echo '' | g++ -shared -fPIC -x c++ - -o $@",
-)
-
-genrule(
-    name = "libswscale_so_4",
-    outs = ["libswscale.so.4"],
-    cmd = "echo '' | g++ -shared -fPIC -x c++ - -o $@",
-)
-
 genrule(
     name = "libavutil_avconfig_h",
     outs = ["libavutil/avconfig.h"],

third_party/libav_9_20.BUILD

@@ -5,10 +5,10 @@ licenses(["notice"])  # LGPL v2.1+ license
 
 exports_files(["LICENSE.md"])
 
-cc_library(
+load("@org_tensorflow//third_party:repo.bzl", "cc_import_library")
+
+cc_import_library(
     name = "libav",
-    srcs = [
-    ],
     hdrs = [
         "libavformat/avformat.h",
         "libavformat/avio.h",
@@ -39,53 +39,14 @@ cc_library(
         "libswscale/swscale.h",
         "libswscale/version.h",
     ],
-    copts = [],
-    defines = [],
-    includes = [],
-    linkopts = [
-        "-L$(GENDIR)/external/libav_9_20",
-        "-l:libavformat.so.54",
-        "-l:libavcodec.so.54",
-        "-l:libavutil.so.52",
-        "-l:libswscale.so.2",
-    ],
-    visibility = ["//visibility:public"],
-    deps = [],
-    data = [
+    libraries = [
         "libavformat.so.54",
         "libavcodec.so.54",
         "libavutil.so.52",
         "libswscale.so.2",
     ],
 )
 
-# Stab library files for build to be successful
-# even when those files are not installed (e.g., Ubuntu 14.04)
-# In runtime (e.g., Ubuntu 18.04) system files will be used.
-genrule(
-    name = "libavformat_so_54",
-    outs = ["libavformat.so.54"],
-    cmd = "echo '' | g++ -shared -fPIC -x c++ - -o $@",
-)
-
-genrule(
-    name = "libavcodec_so_54",
-    outs = ["libavcodec.so.54"],
-    cmd = "echo '' | g++ -shared -fPIC -x c++ - -o $@",
-)
-
-genrule(
-    name = "libavutil_so_52",
-    outs = ["libavutil.so.52"],
-    cmd = "echo '' | g++ -shared -fPIC -x c++ - -o $@",
-)
-
-genrule(
-    name = "libswscale_so_2",
-    outs = ["libswscale.so.2"],
-    cmd = "echo '' | g++ -shared -fPIC -x c++ - -o $@",
-)
-
 genrule(
     name = "libavutil_avconfig_h",
     outs = ["libavutil/avconfig.h"],

third_party/repo.bzl

@@ -0,0 +1,28 @@
+# cc_import_library is a replacement of cc_import in bazel,
+# The purposes are:
+# - Allows the specification of soname e.g., libavformat.so.57
+# - Restrict to only allow linking against for GPL licenses libraries,
+#   so that no srcs files are used.
+def cc_import_library(
+        name,
+        hdrs,
+        libraries,
+        **kwargs):
+    for library in libraries:
+        native.genrule(
+            name = "stub-" + library,
+            outs = [library],
+            cmd = "echo '' | g++ -shared -fPIC -x c++ - -o $@",
+        )
+    native.cc_library(
+        name = name,
+        srcs = [],
+        hdrs = hdrs,
+        copts = [],
+        defines = [],
+        includes = [],
+	linkopts = ["-L$(GENDIR)/external/" + native.repository_name()[1:]] + ["-l:" + x for x in libraries],
+        visibility = ["//visibility:public"],
+        data = libraries,
+        **kwargs
+    )