Skip to content

Commit 06b4e38

Browse files
afrittolitekton-robot
authored andcommitted
Fix namespace in rolebindings
Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
1 parent 2761ad7 commit 06b4e38

File tree

3 files changed

+60
-58
lines changed

3 files changed

+60
-58
lines changed

prow/control-plane/extra.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ apiVersion: v1
2424
kind: ServiceAccount
2525
metadata:
2626
name: prow-config-bot
27+
namespace: default
2728
---
2829
apiVersion: rbac.authorization.k8s.io/v1
2930
kind: RoleBinding

prow/control-plane/prow.yaml

Lines changed: 44 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ spec:
3333
labels:
3434
app: hook
3535
spec:
36-
serviceAccountName: "hook"
36+
serviceAccountName: hook
3737
terminationGracePeriodSeconds: 180
3838
containers:
3939
- name: hook
@@ -204,7 +204,7 @@ spec:
204204
labels:
205205
app: sinker
206206
spec:
207-
serviceAccountName: "sinker"
207+
serviceAccountName: sinker
208208
containers:
209209
- name: sinker
210210
image: gcr.io/k8s-prow/sinker:v20220628-aa928caf31
@@ -259,7 +259,7 @@ spec:
259259
labels:
260260
app: deck
261261
spec:
262-
serviceAccountName: "deck"
262+
serviceAccountName: deck
263263
terminationGracePeriodSeconds: 30
264264
containers:
265265
- name: deck
@@ -368,7 +368,7 @@ spec:
368368
labels:
369369
app: horologium
370370
spec:
371-
serviceAccountName: "horologium"
371+
serviceAccountName: horologium
372372
terminationGracePeriodSeconds: 30
373373
containers:
374374
- name: horologium
@@ -422,7 +422,7 @@ spec:
422422
labels:
423423
app: tide
424424
spec:
425-
serviceAccountName: "tide"
425+
serviceAccountName: tide
426426
containers:
427427
- name: tide
428428
image: gcr.io/k8s-prow/tide:v20220628-aa928caf31
@@ -530,20 +530,20 @@ kind: ServiceAccount
530530
apiVersion: v1
531531
metadata:
532532
namespace: default
533-
name: "deck"
533+
name: deck
534534
---
535535
kind: RoleBinding
536536
apiVersion: rbac.authorization.k8s.io/v1
537537
metadata:
538538
namespace: default
539-
name: "deck"
539+
name: deck
540540
roleRef:
541541
apiGroup: rbac.authorization.k8s.io
542542
kind: Role
543-
name: "deck"
543+
name: deck
544544
subjects:
545545
- kind: ServiceAccount
546-
name: "deck"
546+
name: deck
547547
---
548548
kind: Role
549549
apiVersion: rbac.authorization.k8s.io/v1
@@ -568,13 +568,13 @@ kind: ServiceAccount
568568
apiVersion: v1
569569
metadata:
570570
namespace: default
571-
name: "horologium"
571+
name: horologium
572572
---
573573
kind: Role
574574
apiVersion: rbac.authorization.k8s.io/v1
575575
metadata:
576576
namespace: default
577-
name: "horologium"
577+
name: horologium
578578
rules:
579579
- apiGroups:
580580
- "prow.k8s.io"
@@ -589,26 +589,26 @@ kind: RoleBinding
589589
apiVersion: rbac.authorization.k8s.io/v1
590590
metadata:
591591
namespace: default
592-
name: "horologium"
592+
name: horologium
593593
roleRef:
594594
apiGroup: rbac.authorization.k8s.io
595595
kind: Role
596-
name: "horologium"
596+
name: horologium
597597
subjects:
598598
- kind: ServiceAccount
599-
name: "horologium"
599+
name: horologium
600600
---
601601
apiVersion: v1
602602
kind: ServiceAccount
603603
metadata:
604604
namespace: default
605-
name: "prow-controller-manager"
605+
name: prow-controller-manager
606606
---
607607
kind: Role
608608
apiVersion: rbac.authorization.k8s.io/v1
609609
metadata:
610610
namespace: default
611-
name: "prow-controller-manager"
611+
name: prow-controller-manager
612612
rules:
613613
- apiGroups:
614614
- coordination.k8s.io
@@ -656,26 +656,26 @@ kind: RoleBinding
656656
apiVersion: rbac.authorization.k8s.io/v1
657657
metadata:
658658
namespace: default
659-
name: "prow-controller-manager"
659+
name: prow-controller-manager
660660
roleRef:
661661
apiGroup: rbac.authorization.k8s.io
662662
kind: Role
663-
name: "prow-controller-manager"
663+
name: prow-controller-manager
664664
subjects:
665665
- kind: ServiceAccount
666-
name: "prow-controller-manager"
666+
name: prow-controller-manager
667667
---
668668
kind: ServiceAccount
669669
apiVersion: v1
670670
metadata:
671671
namespace: default
672-
name: "sinker"
672+
name: sinker
673673
---
674674
kind: Role
675675
apiVersion: rbac.authorization.k8s.io/v1
676676
metadata:
677677
namespace: default
678-
name: "sinker"
678+
name: sinker
679679
rules:
680680
- apiGroups:
681681
- "prow.k8s.io"
@@ -722,26 +722,26 @@ kind: RoleBinding
722722
apiVersion: rbac.authorization.k8s.io/v1
723723
metadata:
724724
namespace: default
725-
name: "sinker"
725+
name: sinker
726726
roleRef:
727727
apiGroup: rbac.authorization.k8s.io
728728
kind: Role
729-
name: "sinker"
729+
name: sinker
730730
subjects:
731731
- kind: ServiceAccount
732-
name: "sinker"
732+
name: sinker
733733
---
734734
apiVersion: v1
735735
kind: ServiceAccount
736736
metadata:
737737
namespace: default
738-
name: "hook"
738+
name: hook
739739
---
740740
kind: Role
741741
apiVersion: rbac.authorization.k8s.io/v1
742742
metadata:
743743
namespace: default
744-
name: "hook"
744+
name: hook
745745
rules:
746746
- apiGroups:
747747
- "prow.k8s.io"
@@ -765,26 +765,26 @@ kind: RoleBinding
765765
apiVersion: rbac.authorization.k8s.io/v1
766766
metadata:
767767
namespace: default
768-
name: "hook"
768+
name: hook
769769
roleRef:
770770
apiGroup: rbac.authorization.k8s.io
771771
kind: Role
772-
name: "hook"
772+
name: hook
773773
subjects:
774774
- kind: ServiceAccount
775-
name: "hook"
775+
name: hook
776776
---
777777
apiVersion: v1
778778
kind: ServiceAccount
779779
metadata:
780780
namespace: default
781-
name: "tide"
781+
name: tide
782782
---
783783
kind: Role
784784
apiVersion: rbac.authorization.k8s.io/v1
785785
metadata:
786786
namespace: default
787-
name: "tide"
787+
name: tide
788788
rules:
789789
- apiGroups:
790790
- "prow.k8s.io"
@@ -800,14 +800,14 @@ kind: RoleBinding
800800
apiVersion: rbac.authorization.k8s.io/v1
801801
metadata:
802802
namespace: default
803-
name: "tide"
803+
name: tide
804804
roleRef:
805805
apiGroup: rbac.authorization.k8s.io
806806
kind: Role
807-
name: "tide"
807+
name: tide
808808
subjects:
809809
- kind: ServiceAccount
810-
name: "tide"
810+
name: tide
811811
#---
812812
#
813813
# TODO(#54) The statusreconciler component was added after our initial Prow setup
@@ -816,7 +816,7 @@ subjects:
816816
#kind: ServiceAccount
817817
#metadata:
818818
# namespace: default
819-
# name: "statusreconciler"
819+
# name: statusreconciler
820820
#---
821821
#
822822
# TODO(#54) The statusreconciler component was added after our initial Prow setup
@@ -825,7 +825,7 @@ subjects:
825825
#apiVersion: rbac.authorization.k8s.io/v1
826826
#metadata:
827827
# namespace: default
828-
# name: "statusreconciler"
828+
# name: statusreconciler
829829
#rules:
830830
# - apiGroups:
831831
# - "prow.k8s.io"
@@ -841,19 +841,20 @@ subjects:
841841
#apiVersion: rbac.authorization.k8s.io/v1
842842
#metadata:
843843
# namespace: default
844-
# name: "statusreconciler"
844+
# name: statusreconciler
845845
#roleRef:
846846
# apiGroup: rbac.authorization.k8s.io
847847
# kind: Role
848-
# name: "statusreconciler"
848+
# name: statusreconciler
849849
#subjects:
850850
#- kind: ServiceAccount
851-
# name: "statusreconciler"
851+
# name: statusreconciler
852852
---
853853
kind: ServiceAccount
854854
apiVersion: v1
855855
metadata:
856-
name: "crier"
856+
name: crier
857+
namespace: default
857858
---
858859
kind: ClusterRole
859860
apiVersion: rbac.authorization.k8s.io/v1
@@ -873,15 +874,15 @@ rules:
873874
kind: ClusterRoleBinding
874875
apiVersion: rbac.authorization.k8s.io/v1
875876
metadata:
876-
name: "crier"
877+
name: crier
877878
namespace: "default"
878879
roleRef:
879880
apiGroup: rbac.authorization.k8s.io
880881
kind: ClusterRole
881-
name: "crier"
882+
name: crier
882883
subjects:
883884
- kind: ServiceAccount
884-
name: "crier"
885+
name: crier
885886
namespace: "default"
886887
---
887888
apiVersion: apps/v1

prow/test-pods/prow.yaml

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,15 @@ kind: RoleBinding
2020
apiVersion: rbac.authorization.k8s.io/v1
2121
metadata:
2222
namespace: test-pods
23-
name: "deck"
23+
name: deck
2424
roleRef:
2525
apiGroup: rbac.authorization.k8s.io
2626
kind: Role
27-
name: "deck"
27+
name: deck
2828
subjects:
2929
- kind: ServiceAccount
30-
name: "deck"
31-
namespace: default
30+
name: deck
31+
namespace: prow
3232
---
3333
kind: Role
3434
apiVersion: rbac.authorization.k8s.io/v1
@@ -47,13 +47,13 @@ kind: ServiceAccount
4747
apiVersion: v1
4848
metadata:
4949
namespace: default
50-
name: "horologium"
50+
name: horologium
5151
---
5252
kind: Role
5353
apiVersion: rbac.authorization.k8s.io/v1
5454
metadata:
5555
namespace: test-pods
56-
name: "prow-controller-manager"
56+
name: prow-controller-manager
5757
rules:
5858
- apiGroups:
5959
- ""
@@ -71,21 +71,21 @@ kind: RoleBinding
7171
apiVersion: rbac.authorization.k8s.io/v1
7272
metadata:
7373
namespace: test-pods
74-
name: "prow-controller-manager"
74+
name: prow-controller-manager
7575
roleRef:
7676
apiGroup: rbac.authorization.k8s.io
7777
kind: Role
78-
name: "prow-controller-manager"
78+
name: prow-controller-manager
7979
subjects:
8080
- kind: ServiceAccount
81-
name: "prow-controller-manager"
82-
namespace: default
81+
name: prow-controller-manager
82+
namespace: prow
8383
---
8484
kind: Role
8585
apiVersion: rbac.authorization.k8s.io/v1
8686
metadata:
8787
namespace: test-pods
88-
name: "sinker"
88+
name: sinker
8989
rules:
9090
- apiGroups:
9191
- ""
@@ -102,12 +102,12 @@ kind: RoleBinding
102102
apiVersion: rbac.authorization.k8s.io/v1
103103
metadata:
104104
namespace: test-pods
105-
name: "sinker"
105+
name: sinker
106106
roleRef:
107107
apiGroup: rbac.authorization.k8s.io
108108
kind: Role
109-
name: "sinker"
109+
name: sinker
110110
subjects:
111111
- kind: ServiceAccount
112-
name: "sinker"
113-
namespace: default
112+
name: sinker
113+
namespace: prow

0 commit comments

Comments
 (0)