Skip to content

Commit 0d175f2

Browse files
cappyzawatekton-robot
authored andcommitted
add namespace to GetDownloadSteps
Signed-off-by: cappyzawa <cappyzawa@yahoo.ne.jp> add namespace as cluser3's parameter to input_resource_test Signed-off-by: cappyzawa <cappyzawa@yahoo.ne.jp>
1 parent 840d10a commit 0d175f2

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

pkg/apis/pipeline/v1alpha1/cluster_resource_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ func Test_ClusterResource_GetDownloadSteps(t *testing.T) {
150150
Name: "kubeconfig-9l9zj",
151151
Image: "override-with-kubeconfig-writer:latest",
152152
Command: []string{"/ko-app/kubeconfigwriter"},
153-
Args: []string{"-clusterConfig", `{"name":"test-cluster-resource","type":"cluster","url":"http://10.10.10.10","revision":"","username":"","password":"","token":"","Insecure":false,"cadata":null,"secrets":[{"fieldName":"cadata","secretKey":"cadatakey","secretName":"secret1"}]}`},
153+
Args: []string{"-clusterConfig", `{"name":"test-cluster-resource","type":"cluster","url":"http://10.10.10.10","revision":"","username":"","password":"","namespace":"","token":"","Insecure":false,"cadata":null,"secrets":[{"fieldName":"cadata","secretKey":"cadatakey","secretName":"secret1"}]}`},
154154
Env: []corev1.EnvVar{{
155155
Name: "CADATA",
156156
ValueFrom: &corev1.EnvVarSource{

pkg/reconciler/taskrun/resources/input_resource_test.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,9 @@ func setUp(t *testing.T) {
131131
}, {
132132
Name: "Url",
133133
Value: "http://10.10.10.10",
134+
}, {
135+
Name: "Namespace",
136+
Value: "namespace1",
134137
}, {
135138
Name: "CAdata",
136139
// echo "my-ca-cert" | base64
@@ -639,7 +642,7 @@ func TestAddResourceToTask(t *testing.T) {
639642
Image: "override-with-kubeconfig-writer:latest",
640643
Command: []string{"/ko-app/kubeconfigwriter"},
641644
Args: []string{
642-
"-clusterConfig", `{"name":"cluster3","type":"cluster","url":"http://10.10.10.10","revision":"","username":"","password":"","token":"","Insecure":false,"cadata":"bXktY2EtY2VydAo=","secrets":null}`,
645+
"-clusterConfig", `{"name":"cluster3","type":"cluster","url":"http://10.10.10.10","revision":"","username":"","password":"","namespace":"namespace1","token":"","Insecure":false,"cadata":"bXktY2EtY2VydAo=","secrets":null}`,
643646
},
644647
}}},
645648
},
@@ -681,7 +684,7 @@ func TestAddResourceToTask(t *testing.T) {
681684
Image: "override-with-kubeconfig-writer:latest",
682685
Command: []string{"/ko-app/kubeconfigwriter"},
683686
Args: []string{
684-
"-clusterConfig", `{"name":"cluster2","type":"cluster","url":"http://10.10.10.10","revision":"","username":"","password":"","token":"","Insecure":false,"cadata":null,"secrets":[{"fieldName":"cadata","secretKey":"cadatakey","secretName":"secret1"}]}`,
687+
"-clusterConfig", `{"name":"cluster2","type":"cluster","url":"http://10.10.10.10","revision":"","username":"","password":"","namespace":"","token":"","Insecure":false,"cadata":null,"secrets":[{"fieldName":"cadata","secretKey":"cadatakey","secretName":"secret1"}]}`,
685688
},
686689
Env: []corev1.EnvVar{{
687690
ValueFrom: &corev1.EnvVarSource{

0 commit comments

Comments
 (0)