Skip to content

Commit 0133513

Browse files
Pangjipingtekton-robot
authored andcommitted
chore(pipelinerun): remove cmpopts.SortSlices from pkg/reconciler/pipelinerun/pipelinerun_updatestatus_test.go
1 parent fdbb57c commit 0133513

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

pkg/reconciler/pipelinerun/pipelinerun_updatestatus_test.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ import (
2222
"testing"
2323

2424
"github.com/google/go-cmp/cmp"
25-
"github.com/google/go-cmp/cmp/cmpopts"
2625
"github.com/tektoncd/pipeline/pkg/apis/config"
2726
v1 "github.com/tektoncd/pipeline/pkg/apis/pipeline/v1"
2827
"github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1"
@@ -455,7 +454,7 @@ pipelineTaskName: task
455454
actualPrStatus.ChildReferences = fixedChildRefs
456455
}
457456

458-
if d := cmp.Diff(tc.expectedPrStatus, actualPrStatus, cmpopts.SortSlices(lessChildReferences)); d != "" {
457+
if d := cmp.Diff(tc.expectedPrStatus, actualPrStatus); d != "" {
459458
t.Errorf("expected the PipelineRun status to match %#v. Diff %s", tc.expectedPrStatus, diff.PrintWantGot(d))
460459
}
461460
})
@@ -592,7 +591,7 @@ metadata:
592591

593592
expectedPRStatus := prStatusFromInputs(prRunningStatus, tc.expectedStatusTRs, tc.expectedStatusRuns, tc.expectedStatusCRs)
594593

595-
if d := cmp.Diff(expectedPRStatus, actualPrStatus, cmpopts.SortSlices(lessChildReferences)); d != "" {
594+
if d := cmp.Diff(expectedPRStatus, actualPrStatus); d != "" {
596595
t.Errorf("expected the PipelineRun status to match %#v. Diff %s", expectedPRStatus, diff.PrintWantGot(d))
597596
}
598597
})

0 commit comments

Comments
 (0)