fix: Parse alias correctly with quoted field names including : in select

Resolves #587

Author: DutchGerman

src/Query.js

@@ -83,8 +83,12 @@ class Query extends URL {
       }
       // regular select
       let alias = ''; let field; let cast = ''; let subfields = []
-      if (k.includes(':')) {
-        [alias, field] = k.split(':')
+      if (/^[^"]*:/.test(k)) {
+        // first `:` is outside quotes
+        [alias, field] = k.split(/:(.+)/)
+      } else if (/^".*[^\\]":/.test(k)) {
+        // quoted alias
+        [alias, field] = k.split(/(?<=[^\\]"):(.+)/)
       } else {
         field = k
       }

tests/unit/Query.spec.js

@@ -228,6 +228,35 @@ describe('Query', () => {
         }
       }
     }, 'select=id,jd:json_data::text,bt:json_data->blood_type::integer')
+
+    itt('json field with quoted key', {
+      select: {
+        'some->nested->"https://json-that-needs-quotes"': true
+      }
+    }, 'select=some->nested->"https://json-that-needs-quotes"')
+
+    itt('json field with quoted key and aliased', {
+      select: {
+        'alias:some->nested->"https://json-that-needs-quotes"': true
+      }
+    }, 'select=alias:some->nested->"https://json-that-needs-quotes"')
+
+    itt('json field with quoted nested key', {
+      select: {
+        some: {
+          nested: {
+            '"https://json-that-needs-quotes"': true
+          }
+        }
+      }
+    }, 'select=some->nested->"https://json-that-needs-quotes"'
+    )
+
+    itt('should parse quoted aliases with escaped quotes properly', {
+      select: {
+        '"a:\\":b":"x:y:z"': true
+      }
+    }, 'select="a:\\":b":"x:y:z"')
   })
 
   describe('ordering', () => {