Apply typed properties

Author: MGatner

src/FrontendPublisher.php

@@ -18,17 +18,15 @@ abstract class FrontendPublisher extends Publisher
     /**
      * Destination path relative to AssetsConfig::directory.
      * Must be set by child classes.
-     *
-     * @var string
      */
-    protected $path;
+    protected string $path = '';
 
     /**
      * Set the real destination.
      */
     public function __construct(?string $source = null, ?string $destination = null)
     {
-        if (! is_string($this->path)) {
+        if ($this->path === '') {
             throw new DomainException('Invalid relative destination $path.');
         }
 

src/Publishers/AdminLTEPublisher.php

@@ -6,6 +6,6 @@
 
 class AdminLTEPublisher extends FrontendPublisher
 {
-    protected $source = 'vendor/almasaeed2010/adminlte/dist';
-    protected $path   = 'adminlte';
+    protected $source      = 'vendor/almasaeed2010/adminlte/dist';
+    protected string $path = 'adminlte';
 }

src/Publishers/BootstrapPublisher.php

@@ -6,6 +6,6 @@
 
 class BootstrapPublisher extends FrontendPublisher
 {
-    protected $source = 'vendor/twbs/bootstrap/dist';
-    protected $path   = 'bootstrap';
+    protected $source      = 'vendor/twbs/bootstrap/dist';
+    protected string $path = 'bootstrap';
 }

src/Publishers/DataTablesPublisher.php

@@ -6,8 +6,8 @@
 
 class DataTablesPublisher extends FrontendPublisher
 {
-    protected $source = 'vendor/datatables.net/datatables.net';
-    protected $path   = 'datatables';
+    protected $source      = 'vendor/datatables.net/datatables.net';
+    protected string $path = 'datatables';
 
     /**
      * Reads files from the sources and copies them out to their destinations.

src/Publishers/DataTablesStylePublisher.php

@@ -6,8 +6,8 @@
 
 class DataTablesStylePublisher extends FrontendPublisher
 {
-    protected $source = 'vendor/datatables.net/datatables.net-bs4';
-    protected $path   = 'datatables';
+    protected $source      = 'vendor/datatables.net/datatables.net-bs4';
+    protected string $path = 'datatables';
 
     /**
      * Reads files from the sources and copies them out to their destinations.

src/Publishers/FontAwesomePublisher.php

@@ -6,19 +6,8 @@
 
 class FontAwesomePublisher extends FrontendPublisher
 {
-    /**
-     * @var string
-     */
-    protected $source = 'vendor/fortawesome/font-awesome';
-
-    /**
-     * Destination path relative to AssetsConfig::directory.
-     *
-     * @see FrontendPublisher::__construct()
-     *
-     * @var string
-     */
-    protected $path = 'font-awesome';
+    protected $source      = 'vendor/fortawesome/font-awesome';
+    protected string $path = 'font-awesome';
 
     /**
      * Reads files from the sources and copies them out to their destinations.

src/Publishers/JQueryPublisher.php

@@ -6,6 +6,6 @@
 
 class JQueryPublisher extends FrontendPublisher
 {
-    protected $source = 'vendor/components/jquery';
-    protected $path   = 'jquery';
+    protected $source      = 'vendor/components/jquery';
+    protected string $path = 'jquery';
 }

tests/FrontendPublisherTest.php

@@ -25,8 +25,8 @@ public function testPublisherSetsDestination()
         // Allow publishing to the test folder
         config('Publisher')->restrictions[SUPPORTPATH] = '*';
 
-        $publisher          = new class () extends FrontendPublisher {
-            protected $path = 'foobar';
+        $publisher                 = new class () extends FrontendPublisher {
+            protected string $path = 'foobar';
         };
 
         $this->assertSame($this->assets->directory . 'vendor/foobar/', $publisher->getDestination());