Skip to content

return data and errors acc. spec #7.1.2 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2021

Conversation

no1seman
Copy link

According to http://spec.graphql.org/draft/#sec-Errors executor must be able to return data or errors or data and errors

closes #11

@no1seman no1seman requested review from olegrok, RunsFor and rosik March 27, 2021 08:27
Copy link
Collaborator

@olegrok olegrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patch. See one comment below. Also please add some tests covered your change.

@no1seman no1seman requested a review from olegrok March 29, 2021 11:01
@no1seman no1seman force-pushed the ret_data_and_error branch from cd77c34 to dd425ea Compare March 29, 2021 11:19
@no1seman no1seman requested a review from olegrok March 29, 2021 11:22
Copy link

@rosik rosik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cartridge tests seem to be OK with this change (including cypress).

@no1seman no1seman requested a review from rosik March 29, 2021 13:55
@olegrok olegrok merged commit 32c97f0 into tarantool:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Executor must return not only data or errors but also both of them
3 participants