Skip to content

Commit 7d3772c

Browse files
no1semanno1seman
committed
Propagate defaults to operation callback
Before this PR there is no fast and convenient way to get operation and directives defaults set when creating the schema. Now it's possible, operation and directives default can be easily found is in the #3 argument of callback - map "info". The keys are: defaultValues - for operation defaults directivesDefaultValues - for directives defaults
1 parent b8f86bc commit 7d3772c

File tree

3 files changed

+295
-3
lines changed

3 files changed

+295
-3
lines changed

‎graphql/execute.lua

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -335,6 +335,7 @@ local function getFieldEntry(objectType, object, fields, context)
335335
variableValues = context.variables,
336336
defaultValues = context.defaultValues,
337337
directives = directives,
338+
directivesDefaultValues = context.schema.directivesDefaultValues,
338339
}
339340

340341
local resolvedObject, err = (fieldType.resolve or defaultResolver)(object, arguments, info)
@@ -352,9 +353,27 @@ evaluateSelections = function(objectType, object, selections, context)
352353
local result = {}
353354
local err
354355
local fields = collectFields(objectType, selections, {}, {}, context)
356+
local defaultValues
357+
358+
if context.defaultValues == nil then
359+
if context.schema.defaultValues ~= nil and type(context.schema.defaultValues) == 'table' then
360+
local operationDefaults = context.schema.defaultValues[context.operation.operation]
361+
if operationDefaults ~= nil and type(operationDefaults) == 'table' then
362+
defaultValues = context.schema.defaultValues[context.operation.operation]
363+
end
364+
end
365+
else
366+
defaultValues = context.defaultValues
367+
end
368+
355369
for _, field in ipairs(fields) do
356370
assert(result[field.name] == nil,
357371
'two selections into the one field: ' .. field.name)
372+
373+
if defaultValues ~= nil then
374+
context.defaultValues = defaultValues[field.name]
375+
end
376+
358377
result[field.name], err = getFieldEntry(objectType, object, {field.selection},
359378
context)
360379
if err ~= nil then

‎graphql/schema.lua

Lines changed: 95 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,11 @@ end
88
local schema = {}
99
schema.__index = schema
1010

11-
function schema.create(config, name)
11+
function schema.create(config, name, opts)
1212
assert(type(config.query) == 'table', 'must provide query object')
1313
assert(not config.mutation or type(config.mutation) == 'table', 'mutation must be a table if provided')
1414

15+
opts = opts or {}
1516
local self = setmetatable({}, schema)
1617

1718
for k, v in pairs(config) do
@@ -34,9 +35,101 @@ function schema.create(config, name)
3435
self:generateTypeMap(introspection.__Schema)
3536
self:generateDirectiveMap()
3637

38+
if opts.defaultValues == true then
39+
self.defaultValues = {}
40+
self.defaultValues.mutation = self:extractDefaults(self.mutation)
41+
self.defaultValues.query = self:extractDefaults(self.query)
42+
end
43+
44+
if opts.directivesDefaultValues == true then
45+
self.directivesDefaultValues = {}
46+
47+
for directiveName, directive in pairs(self.directiveMap or {}) do
48+
self.directivesDefaultValues[directiveName] = self:extractDefaults(directive)
49+
end
50+
end
51+
3752
return self
3853
end
3954

55+
function schema:extractDefaults(node)
56+
if not node then return end
57+
58+
local defaultValues
59+
local nodeType = node.__type ~= nil and node or node.kind
60+
61+
if nodeType.__type == 'NonNull' then
62+
return self:extractDefaults(nodeType.ofType)
63+
end
64+
65+
if nodeType.__type == 'Enum' then
66+
return node.defaultValue
67+
end
68+
69+
if nodeType.__type == 'Scalar' then
70+
return node.defaultValue
71+
end
72+
73+
node.fields = type(node.fields) == 'function' and node.fields() or node.fields
74+
75+
if nodeType.__type == 'Object' or nodeType.__type == 'InputObject' then
76+
for fieldName, field in pairs(nodeType.fields or {}) do
77+
local fieldDefaultValue = self:extractDefaults(field)
78+
if fieldDefaultValue ~= nil then
79+
defaultValues = defaultValues or {}
80+
defaultValues[fieldName] = fieldDefaultValue
81+
end
82+
83+
for argumentName, argument in pairs(field.arguments or {}) do
84+
-- BEGIN_HACK: resolve type names to real types
85+
if type(argument) == 'string' then
86+
argument = types.resolve(argument, self.name)
87+
field.arguments[argumentName] = argument
88+
end
89+
90+
if type(argument.kind) == 'string' then
91+
argument.kind = types.resolve(argument.kind, self.name)
92+
end
93+
-- END_HACK: resolve type names to real types
94+
95+
local argumentDefaultValue = self:extractDefaults(argument)
96+
if argumentDefaultValue ~= nil then
97+
defaultValues = defaultValues or {}
98+
defaultValues[fieldName] = defaultValues[fieldName] or {}
99+
defaultValues[fieldName][argumentName] = argumentDefaultValue
100+
end
101+
end
102+
end
103+
return defaultValues
104+
end
105+
106+
if nodeType.__type =='Directive' then
107+
for argumentName, argument in pairs(nodeType.arguments or {}) do
108+
-- BEGIN_HACK: resolve type names to real types
109+
if type(argument) == 'string' then
110+
argument = types.resolve(argument, self.name)
111+
nodeType.arguments[argumentName] = argument
112+
end
113+
114+
if type(argument.kind) == 'string' then
115+
argument.kind = types.resolve(argument.kind, self.name)
116+
end
117+
-- END_HACK: resolve type names to real types
118+
119+
local argumentDefaultValue = self:extractDefaults(argument)
120+
if argumentDefaultValue ~= nil then
121+
defaultValues = defaultValues or {}
122+
defaultValues[argumentName] = argumentDefaultValue
123+
end
124+
end
125+
return defaultValues
126+
end
127+
128+
if nodeType.__type == 'List' then
129+
return self:extractDefaults(nodeType.ofType)
130+
end
131+
end
132+
40133
function schema:generateTypeMap(node)
41134
if not node or (self.typeMap[node.name] and self.typeMap[node.name] == node) then return end
42135

@@ -117,7 +210,7 @@ function schema:generateDirectiveMap()
117210
if argumentType == nil then
118211
error('Must supply type for argument "' .. name .. '" on "' .. directive.name .. '"')
119212
end
120-
argumentType.defaultValue = argument.defaultValue
213+
-- argumentType.defaultValue = argument.defaultValue
121214
self:generateTypeMap(argumentType)
122215
end
123216
end

‎test/integration/graphql_test.lua

Lines changed: 181 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ local function check_request(query, query_schema, mutation_schema, directives, o
2525
directives = directives,
2626
}
2727

28-
local compiled_schema = schema.create(root, test_schema_name)
28+
local compiled_schema = schema.create(root, test_schema_name, opts)
2929

3030
local parsed = parse.parse(query)
3131

@@ -1804,3 +1804,183 @@ function g.test_skip_include_directives()
18041804
t.assert_equals(errors, nil)
18051805
t.assert_items_equals(data, {test = {uri = "uri1", uris = {uri = "uri2"}}})
18061806
end
1807+
1808+
g.test_propagate_defaults_to_callback = function()
1809+
local query = '{test_mutation}'
1810+
1811+
local function callback(_, _, info)
1812+
return json.encode({
1813+
defaultValues = info.defaultValues,
1814+
directivesDefaultValues = info.directivesDefaultValues,
1815+
})
1816+
end
1817+
1818+
local input_object = types.inputObject({
1819+
name = 'test_input_object',
1820+
fields = {
1821+
nested_int_arg = {
1822+
kind = types.int,
1823+
defaultValue = 2,
1824+
},
1825+
nested_string_arg = {
1826+
kind = types.string,
1827+
defaultValue = 'default nested value',
1828+
},
1829+
nested_boolean_arg = {
1830+
kind = types.boolean,
1831+
defaultValue = true,
1832+
},
1833+
nested_float_arg = {
1834+
kind = types.float,
1835+
defaultValue = 1.1,
1836+
},
1837+
nested_long_arg = {
1838+
kind = types.long,
1839+
defaultValue = 2^50,
1840+
},
1841+
nested_list_scalar_arg = {
1842+
kind = types.list(types.string),
1843+
-- defaultValue seems illogical
1844+
}
1845+
},
1846+
kind = types.string,
1847+
})
1848+
1849+
local mutation_schema = {
1850+
['test_mutation'] = {
1851+
kind = types.string.nonNull,
1852+
arguments = {
1853+
int_arg = {
1854+
kind = types.int,
1855+
defaultValue = 1,
1856+
},
1857+
string_arg = {
1858+
kind = types.string,
1859+
defaultValue = 'string_arg'
1860+
},
1861+
boolean_arg = {
1862+
kind = types.boolean,
1863+
defaultValue = false,
1864+
},
1865+
float_arg = {
1866+
kind = types.float,
1867+
defaultValue = 1.1,
1868+
},
1869+
long_arg = {
1870+
kind = types.long,
1871+
defaultValue = 2^50,
1872+
},
1873+
object_arg = {
1874+
kind = input_object,
1875+
-- defaultValue seems illogical
1876+
},
1877+
list_scalar_arg = {
1878+
kind = types.list(types.string),
1879+
-- defaultValue seems illogical
1880+
}
1881+
},
1882+
resolve = callback,
1883+
}
1884+
}
1885+
1886+
local directives = {
1887+
types.directive({
1888+
schema = schema,
1889+
name = 'timeout',
1890+
description = 'Request execute timeout',
1891+
arguments = {
1892+
int_arg = {
1893+
kind = types.int,
1894+
defaultValue = 1,
1895+
},
1896+
string_arg = {
1897+
kind = types.string,
1898+
defaultValue = 'string_arg'
1899+
},
1900+
boolean_arg = {
1901+
kind = types.boolean,
1902+
defaultValue = false,
1903+
},
1904+
float_arg = {
1905+
kind = types.float,
1906+
defaultValue = 1.1,
1907+
},
1908+
long_arg = {
1909+
kind = types.long,
1910+
defaultValue = 2^50,
1911+
},
1912+
object = input_object
1913+
},
1914+
onField = true,
1915+
})
1916+
}
1917+
1918+
local result = {
1919+
defaultValues = {
1920+
boolean_arg = false,
1921+
int_arg = 1,
1922+
float_arg = 1.1,
1923+
long_arg = 1125899906842624LL,
1924+
object_arg = {
1925+
nested_boolean_arg = true,
1926+
nested_float_arg = 1.1,
1927+
nested_int_arg = 2,
1928+
nested_long_arg = 1125899906842624LL,
1929+
nested_string_arg = "default nested value",
1930+
},
1931+
string_arg = "string_arg",
1932+
},
1933+
directivesDefaultValues = {
1934+
timeout = {
1935+
boolean_arg = false,
1936+
float_arg = 1.1,
1937+
int_arg = 1,
1938+
long_arg = 1125899906842624LL,
1939+
object = {
1940+
nested_boolean_arg = true,
1941+
nested_float_arg = 1.1,
1942+
nested_int_arg = 2,
1943+
nested_long_arg = 1125899906842624LL,
1944+
nested_string_arg = "default nested value",
1945+
},
1946+
string_arg = "string_arg",
1947+
},
1948+
},
1949+
}
1950+
1951+
local data, errors = check_request(
1952+
query,
1953+
mutation_schema,
1954+
nil,
1955+
directives,
1956+
{ defaultValues = true, directivesDefaultValues = true, }
1957+
)
1958+
1959+
t.assert_equals(errors, nil)
1960+
t.assert_items_equals(json.decode(data.test_mutation), result)
1961+
1962+
query = '{prefix{test_mutation}}'
1963+
1964+
local mutation_schema_with_prefix = {
1965+
['prefix'] = {
1966+
kind = types.object({
1967+
name = 'prefix',
1968+
fields = mutation_schema,
1969+
}),
1970+
arguments = {},
1971+
resolve = function()
1972+
return {}
1973+
end,
1974+
}
1975+
}
1976+
1977+
data, errors = check_request(
1978+
query,
1979+
mutation_schema_with_prefix,
1980+
nil,
1981+
directives,
1982+
{ defaultValues = true, directivesDefaultValues = true, }
1983+
)
1984+
t.assert_equals(errors, nil)
1985+
t.assert_items_equals(json.decode(data.prefix.test_mutation), result)
1986+
end

0 commit comments

Comments
 (0)