Skip to content

Commit 8b3a77e

Browse files
committed
[Tests] fix thrower stack in node 0.8
1 parent 995ddb2 commit 8b3a77e

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

test/throws.js

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,14 @@ function getNonFunctionMessage(fn) {
1616
}
1717
}
1818

19+
var getter = function () { return 'message'; };
20+
var messageGetterError = Object.defineProperty(
21+
{ custom: 'error' },
22+
'message',
23+
{ configurable: true, enumerable: true, get: getter }
24+
);
25+
var thrower = function () { throw messageGetterError; };
26+
1927
tap.test('failures', function (tt) {
2028
tt.plan(1);
2129

@@ -173,14 +181,8 @@ tap.test('failures', function (tt) {
173181

174182
test('custom error messages', function (t) {
175183
t.plan(3);
176-
var getter = function () { return 'message'; };
177-
var messageGetterError = Object.defineProperty(
178-
{ custom: 'error' },
179-
'message',
180-
{ configurable: true, enumerable: true, get: getter }
181-
);
182184
t.equal(Object.prototype.propertyIsEnumerable.call(messageGetterError, 'message'), true, '"message" is enumerable');
183-
t.throws(function () { throw messageGetterError; }, "{ custom: 'error', message: 'message' }");
185+
t.throws(thrower, "{ custom: 'error', message: 'message' }");
184186
t.equal(Object.getOwnPropertyDescriptor(messageGetterError, 'message').get, getter, 'getter is still the same');
185187
});
186188

0 commit comments

Comments
 (0)