Fix resolution of imported CSS files in Vite SSR builds#15279
Merged
thecrypticace merged 7 commits intoDec 2, 2024
Conversation
Contributor
|
Ah this is interesting. I was just heads down looking into this and found it was related to SSR when the user config explicitly overrides This fixes it in Vite 5 but isn't needed at all Vite 6 because it just works as expected. Gonna look into the |
Contributor
|
I think this fix is the correct one. Looking into it (and the original problem) the Just needs tests (don't worry I'm gonna add these)! |
The describe block isn’t necessary
thecrypticace
approved these changes
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems this change makes the below mentioned issue go away and seems to generate the correct tailwindcss output file durring the ssr build. Big shoutout to @rossipedia for figuring this out.
I think you guys might want to take this over and own it as I'm not sure about other implications and if it breaks any other framework.
Fixes #15237