Vite: Simplify preprocessor to make it work with Svelte 5 and Vite 6#15274
Merged
Conversation
|
Thanks for working on this! |
It’s not necessary
We require at least Vite 5.2 but also support Vite 6
thecrypticace
approved these changes
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15250
This PR simplifies our Vite integration even more. It turns out that in some projects (see #15250 for the exact repro), the way we invoke
svelte-preprocesswas actually causing issues in Vite since with Vite, it's expected to use thesveltePreprocessversion exported bysveltejs/vite-plugin-svelte.While trying to change this we noticed that there are different versions of
sveltejs/vite-plugin-sveltefor Vite 5 and Vite 6 which caused us to investigate even more and we noticed that we do not even need to recursively call into thesveltePreprocess()as every plugin is run after each other anyways. This allows us to drop the dependency onsvelte-preprocessand simplify the code a bit more, registering only a(string) => stringstyle transformer.Test Plan
This was tsted on the repro repo from #15250 as well as the SvelteKit setup from my playgrounds. Furthermore we tested various combinations of
svelte,@sveltejs/vite-plugin-svelteandvitein our integration test to ensure everything works as expected.