fix(notification channels): avoid drift on send_test_notification = true #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbonf
force-pushed
the
fix-drift-send-test-notification
branch
3 times, most recently
from
cc4f747 to
cc3016b
Compare
dbonf
requested review from
airadier,
tembleking,
mateobur,
michelevergnano,
dkutsanov and
antonio-cuomo
as code owners
dbonf
force-pushed
the
fix-drift-send-test-notification
branch
from
cc3016b to
2ff5d3b
Compare
dbonf
force-pushed
the
fix-drift-send-test-notification
branch
from
2ff5d3b to
f822fa9
Compare
antonio-cuomo
approved these changes
Aug 4, 2025
dkutsanov
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid setting in tf state
send_test_notificationtaken from the api response, as it is always false, since this field is write only there.