bug #262 Fixed some "undefined variables" error in checkInstallerVersion() (javiereguiluz)

This PR was merged into the 1.0-dev branch.

Discussion
----------

Fixed some "undefined variables" error in checkInstallerVersion()

This fixes this error:

![installer_issues](https://cloud.githubusercontent.com/assets/73419/16358153/daf401d8-3b0b-11e6-8be1-8d2126564926.png)

Commits
-------

3258bf7 Fixed some "undefined variables" error in checkInstallerVersion()

Author: javiereguiluz

src/Symfony/Installer/DownloadCommand.php

@@ -62,6 +62,16 @@ abstract class DownloadCommand extends Command
      */
     protected $version = 'latest';
 
+    /**
+     * @var string The latest installer version
+     */
+    private $latestInstallerVersion;
+
+    /**
+     * @var string The version of the local installer being executed
+     */
+    private $localInstallerVersion;
+
     /**
      * @var string The path to the downloaded file
      */
@@ -95,6 +105,9 @@ protected function initialize(InputInterface $input, OutputInterface $output)
         $this->output = $output;
         $this->fs = new Filesystem();
 
+        $this->latestInstallerVersion = $this->getUrlContents(Application::VERSIONS_URL);
+        $this->localInstallerVersion = $this->getApplication()->getVersion();
+
         $this->enableSignalHandler();
     }
 
@@ -558,7 +571,7 @@ protected function checkInstallerVersion()
             $this->output->writeln(sprintf(
                 "\n <bg=red> WARNING </> Your Symfony Installer version (%s) is outdated.\n".
                 ' Execute the command "%s selfupdate" to get the latest version (%s).',
-                $installedVersion, $_SERVER['PHP_SELF'], $latestVersion
+                $this->localInstallerVersion, $_SERVER['PHP_SELF'], $this->latestInstallerVersion
             ));
         }
 
@@ -570,10 +583,7 @@ protected function checkInstallerVersion()
      */
     protected function isInstallerUpdated()
     {
-        $installedVersion = $this->getApplication()->getVersion();
-        $latestVersion = $this->getUrlContents(Application::VERSIONS_URL);
-
-        return version_compare($installedVersion, $latestVersion, '>=');
+        return version_compare($this->localInstallerVersion, $this->latestInstallerVersion, '>=');
     }
 
     /**