feature #221 Checking that symfony installer is up-to-date (jzawadzki)

This PR was squashed before being merged into the 1.0-dev branch (closes #221).

Discussion
----------

Checking that symfony installer is up-to-date

Hi,

regarding our discussion in #220 and #136 I'm sending first draft of checking if installer is up-to-date.
I have based my solution of how and when composer is checking it.
Please comment and tell if this solution is ok and what should I change to make it better!

Thanks,
JZ

Commits
-------

b5225d8 Checking that symfony installer is up-to-date

Author: javiereguiluz

src/Symfony/Installer/Application.php

@@ -0,0 +1,66 @@
+<?php
+
+/*
+ * This file is part of the Symfony Installer package.
+ *
+ * (c) Fabien Potencier <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Installer;
+
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Output\OutputInterface;
+use Symfony\Component\Console\Application as ConsoleApplication;
+
+/**
+ * This is main Symfony Installer console application class.
+ */
+class Application extends ConsoleApplication
+{
+    const VERSIONS_URL = 'https://get.symfony.com/symfony.version';
+
+    public function doRun(InputInterface $input, OutputInterface $output)
+    {
+        $commandName = $this->getCommandName($input);
+
+        if ($this->isInPharMode() && in_array($commandName, array('new', 'demo'), true)) {
+            if (!$this->checkIfInstallerIsUpdated()) {
+                $output->writeln(
+                    sprintf(
+                        " <comment>[WARNING]</comment> You are using outdated version of Symfony Installer.\n".
+                        ' It is recommended to update it by running "%s selfupdate" to get the latest version.',
+                        $_SERVER['PHP_SELF']
+                    )
+                );
+            }
+
+        }
+
+        return parent::doRun($input, $output);
+    }
+
+    public function isInPharMode()
+    {
+        return 'phar://' === substr(__DIR__, 0, 7);
+    }
+
+    private function checkIfInstallerIsUpdated()
+    {
+        $localVersion = $this->getVersion();
+
+        if (false === $remoteVersion = @file_get_contents(self::VERSIONS_URL)) {
+            // as this is simple checking - we don't care here if versions file is unavailable
+            return true;
+        }
+
+        if (version_compare($localVersion, $remoteVersion, '>=')) {
+            return true;
+        }
+
+        return false;
+    }
+
+}

src/Symfony/Installer/SelfUpdateCommand.php

@@ -122,7 +122,7 @@ private function installerIsUpdated()
         $isUpdated = false;
         $localVersion = $this->getApplication()->getVersion();
 
-        if (false === $remoteVersion = @file_get_contents('http://get.symfony.com/symfony.version')) {
+        if (false === $remoteVersion = @file_get_contents(Application::VERSIONS_URL)) {
             throw new \RuntimeException('The new version of the Symfony Installer couldn\'t be downloaded from the server.');
         }
 

symfony

@@ -25,7 +25,7 @@ if (!isset($_SERVER['PATH']) && isset($_SERVER['Path'])) {
     $_SERVER['PATH'] = $_SERVER['Path'];
 }
 
-$app = new Symfony\Component\Console\Application('Symfony Installer', $appVersion);
+$app = new Symfony\Installer\Application('Symfony Installer', $appVersion);
 $app->add(new Symfony\Installer\AboutCommand($appVersion));
 $app->add(new Symfony\Installer\NewCommand());
 $app->add(new Symfony\Installer\DemoCommand());