Skip to content
This repository was archived by the owner on May 31, 2024. It is now read-only.

Commit f8bfe95

Browse files
AndrolGenhaldfabpot
authored andcommitted
Fix AbstractFormLoginAuthenticator return types (fixes #47571).
Children of AbstractFormLoginAuthenticator should be allowed to return a `Response` instead of being required to return a `RedirectResponse`. This change matches the return types in the newer AbstractLoginFormAuthenticator.
1 parent cd44425 commit f8bfe95

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

Guard/Authenticator/AbstractFormLoginAuthenticator.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
use Symfony\Component\HttpFoundation\RedirectResponse;
1515
use Symfony\Component\HttpFoundation\Request;
16+
use Symfony\Component\HttpFoundation\Response;
1617
use Symfony\Component\Security\Core\Exception\AuthenticationException;
1718
use Symfony\Component\Security\Core\Security;
1819
use Symfony\Component\Security\Guard\AbstractGuardAuthenticator;
@@ -34,7 +35,7 @@ abstract protected function getLoginUrl();
3435
/**
3536
* Override to change what happens after a bad username/password is submitted.
3637
*
37-
* @return RedirectResponse
38+
* @return Response
3839
*/
3940
public function onAuthenticationFailure(Request $request, AuthenticationException $exception)
4041
{
@@ -56,7 +57,7 @@ public function supportsRememberMe()
5657
* Override to control what happens when the user hits a secure page
5758
* but isn't logged in yet.
5859
*
59-
* @return RedirectResponse
60+
* @return Response
6061
*/
6162
public function start(Request $request, AuthenticationException $authException = null)
6263
{

0 commit comments

Comments
 (0)