Leverage symfony-tools/fabbot

Author: nicolas-grekas

.github/workflows/fabbot.yml

@@ -0,0 +1,14 @@
+name: CS
+
+on:
+  pull_request:
+
+permissions:
+  contents: read
+
+jobs:
+  call-fabbot:
+    name: Fabbot
+    uses: symfony-tools/fabbot/.github/workflows/fabbot.yml@main
+    with:
+      package: Mercure

src/Authorization.php

@@ -79,7 +79,7 @@ public function createCookie(Request $request, $subscribe = [], $publish = [], a
         $hubInstance = $this->registry->getHub($hub);
         $tokenFactory = $hubInstance->getFactory();
         if (null === $tokenFactory) {
-            $message = sprintf('The %s hub does not contain a token factory.', $hub ? "\"$hub\"" : 'default');
+            $message = \sprintf('The %s hub does not contain a token factory.', $hub ? "\"$hub\"" : 'default');
             throw new InvalidArgumentException($message);
         }
 
@@ -170,14 +170,14 @@ private function getCookieDomain(Request $request, array $urlComponents): ?strin
             }
         }
 
-        throw new RuntimeException(sprintf('Unable to create authorization cookie for a hub on the different second-level domain "%s".', $cookieDomain));
+        throw new RuntimeException(\sprintf('Unable to create authorization cookie for a hub on the different second-level domain "%s".', $cookieDomain));
     }
 
     private function updateCookies(Request $request, ?string $hub, Cookie $cookie): void
     {
         $cookies = $request->attributes->get('_mercure_authorization_cookies', []);
         if (\array_key_exists($hub, $cookies)) {
-            $message = sprintf('The "mercureAuthorization" cookie for the "%s" has already been set. You cannot set it two times during the same request.', $hub ? "\"$hub\" hub" : 'default hub');
+            $message = \sprintf('The "mercureAuthorization" cookie for the "%s" has already been set. You cannot set it two times during the same request.', $hub ? "\"$hub\" hub" : 'default hub');
             throw new RuntimeException($message);
         }
 

src/Debug/TraceablePublisher.php

@@ -27,7 +27,7 @@
  *
  * @experimental
  *
- * @deprecated
+ * @deprecated since Mercure 0.5
  */
 final class TraceablePublisher implements PublisherInterface, ResetInterface
 {

src/EventSubscriber/SetCookieSubscriber.php

@@ -28,8 +28,9 @@ public function onKernelResponse(ResponseEvent $event): void
     {
         $mainRequest = method_exists($event, 'isMainRequest') ? $event->isMainRequest() : $event->isMasterRequest(); /* @phpstan-ignore-line */
         if (
-            !($mainRequest) ||
-            null === $cookies = ($request = $event->getRequest())->attributes->get('_mercure_authorization_cookies')) {
+            !$mainRequest
+            || null === $cookies = ($request = $event->getRequest())->attributes->get('_mercure_authorization_cookies')
+        ) {
             return;
         }
 
@@ -41,9 +42,6 @@ public function onKernelResponse(ResponseEvent $event): void
         }
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public static function getSubscribedEvents(): array
     {
         return [KernelEvents::RESPONSE => 'onKernelResponse'];

src/Exception/InvalidArgumentException.php

@@ -25,6 +25,6 @@ final class InvalidArgumentException extends \InvalidArgumentException implement
      */
     public static function forInvalidAlgorithm(string $algorithm, array $supportedAlgorithms): self
     {
-        return new self(sprintf('Unsupported algorithm "%s", expected one of "%s".', $algorithm, implode('", "', $supportedAlgorithms)));
+        return new self(\sprintf('Unsupported algorithm "%s", expected one of "%s".', $algorithm, implode('", "', $supportedAlgorithms)));
     }
 }

src/Hub.php

@@ -37,7 +37,7 @@ public function __construct(
         TokenProviderInterface $jwtProvider,
         ?TokenFactoryInterface $jwtFactory = null,
         ?string $publicUrl = null,
-        ?HttpClientInterface $httpClient = null
+        ?HttpClientInterface $httpClient = null,
     ) {
         $this->url = $url;
         $this->jwtProvider = $jwtProvider;

src/Internal/QueryBuilder.php

@@ -45,6 +45,6 @@ public static function build(array $data): string
     private static function encode($key, $value): string
     {
         // All Mercure's keys are safe, so don't need to be encoded, but it's not a generic solution
-        return sprintf('%s=%s', $key, urlencode((string) $value));
+        return \sprintf('%s=%s', $key, urlencode((string) $value));
     }
 }

src/Jwt/LcobucciFactory.php

@@ -64,9 +64,6 @@ public function __construct(string $secret, string $algorithm = 'hmac.sha256', ?
         $this->jwtLifetime = 0 === $jwtLifetime ? ((int) \ini_get('session.cookie_lifetime') ?: 3600) : $jwtLifetime;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function create(?array $subscribe = [], ?array $publish = [], array $additionalClaims = []): string
     {
         $builder = $this->configurations->builder();

src/Jwt/StaticJwtProvider.php

@@ -22,7 +22,7 @@
  *
  * @experimental
  *
- * @deprecated
+ * @deprecated since Mercure 0.5
  */
 final class StaticJwtProvider
 {

src/MockHub.php

@@ -32,7 +32,7 @@ public function __construct(
         TokenProviderInterface $jwtProvider,
         callable $publisher,
         ?TokenFactoryInterface $jwtFactory = null,
-        ?string $publicUrl = null
+        ?string $publicUrl = null,
     ) {
         $this->url = $url;
         $this->jwtProvider = $jwtProvider;