Apply review: use AsTwigFunction attribute

Author: qdequippe

src/Twig/MercureExtension.php

@@ -13,18 +13,69 @@
 
 namespace Symfony\Component\Mercure\Twig;
 
-use Twig\Extension\AbstractExtension;
-use Twig\TwigFunction;
+use Symfony\Component\HttpFoundation\RequestStack;
+use Symfony\Component\Mercure\Authorization;
+use Symfony\Component\Mercure\HubRegistry;
+use Twig\Attribute\AsTwigFunction;
 
 /**
  * Registers the Twig helper function.
  *
  * @author Kévin Dunglas <[email protected]>
  */
-final class MercureExtension extends AbstractExtension
+final class MercureExtension
 {
-    public function getFunctions(): array
+    private $hubRegistry;
+    private $authorization;
+    private $requestStack;
+
+    public function __construct(HubRegistry $hubRegistry, ?Authorization $authorization = null, ?RequestStack $requestStack = null)
+    {
+        $this->hubRegistry = $hubRegistry;
+        $this->authorization = $authorization;
+        $this->requestStack = $requestStack;
+    }
+
+    /**
+     * @param string|string[]|null                                                                                                                       $topics  A topic or an array of topics to subscribe for. If this parameter is omitted or `null` is passed, the URL of the hub will be returned (useful for publishing in JavaScript).
+     * @param array{subscribe?: string[]|string, publish?: string[]|string, additionalClaims?: array<string, mixed>, lastEventId?: string, hub?: string} $options The options to pass to the JWT factory
+     *
+     * @return string The URL of the hub with the appropriate "topic" query parameters (if any)
+     */
+    #[AsTwigFunction('mercure')]
+    public function mercure($topics = null, array $options = []): string
     {
-        return [new TwigFunction('mercure', [MercureRuntime::class, 'mercure'])];
+        $hub = $options['hub'] ?? null;
+        $url = $this->hubRegistry->getHub($hub)->getPublicUrl();
+        if (null !== $topics) {
+            // We cannot use http_build_query() because this method doesn't support generating multiple query parameters with the same name without the [] suffix
+            $separator = '?';
+            foreach ((array) $topics as $topic) {
+                $url .= $separator.'topic='.rawurlencode($topic);
+                if ('?' === $separator) {
+                    $separator = '&';
+                }
+            }
+        }
+
+        if ('' !== ($options['lastEventId'] ?? '')) {
+            $encodedLastEventId = rawurlencode($options['lastEventId']);
+            // Last-Event-ID is kept for compatibility with older versions of the protocol: https://mercure.rocks/docs/UPGRADE#0-14
+            $url .= "&lastEventID=$encodedLastEventId&Last-Event-ID=$encodedLastEventId";
+        }
+
+        if (
+            null === $this->authorization
+            || null === $this->requestStack
+            || (!isset($options['subscribe']) && !isset($options['publish']) && !isset($options['additionalClaims']))
+            /* @phpstan-ignore-next-line */
+            || null === $request = method_exists($this->requestStack, 'getMainRequest') ? $this->requestStack->getMainRequest() : $this->requestStack->getMasterRequest()
+        ) {
+            return $url;
+        }
+
+        $this->authorization->setCookie($request, $options['subscribe'] ?? [], $options['publish'] ?? [], $options['additionalClaims'] ?? [], $hub);
+
+        return $url;
     }
 }