Skip to content

Commit 6f69f18

Browse files
committed
Remove an incorrect FIXME.
There is only one lock per target (not per lldb::Module) so that comment was incorrect. rdar://67587895
1 parent 5b34bed commit 6f69f18

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

lldb/source/Target/SwiftLanguageRuntimeDynamicTypeResolution.cpp

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2659,18 +2659,15 @@ const swift::reflection::TypeInfo *SwiftLanguageRuntimeImpl::GetTypeInfo(
26592659

26602660
// Resolve all type aliases.
26612661
type = type.GetCanonicalType();
2662-
2662+
26632663
// Resolve all generic type parameters in the type for the current
2664-
// frame. Archetype binding has to happen in the scratch context,
2665-
// so we lock it while we are in this function.
2664+
// frame. Generic parameter binding has to happen in the scratch
2665+
// context, so we lock it while we are in this function.
26662666
std::unique_ptr<SwiftASTContextLock> lock;
26672667
if (exe_scope)
26682668
if (StackFrame *frame = exe_scope->CalculateStackFrame().get()) {
26692669
ExecutionContext exe_ctx;
2670-
// FIXME: Should be
2671-
// frame->CalculateExecutionContext(exe_ctx);
2672-
// but all the other functions currently get this wrong, too!
2673-
m_process.GetTarget().CalculateExecutionContext(exe_ctx);
2670+
frame->CalculateExecutionContext(exe_ctx);
26742671
lock = std::make_unique<SwiftASTContextLock>(&exe_ctx);
26752672
type = BindGenericTypeParameters(*frame, type);
26762673
}

0 commit comments

Comments
 (0)