Properly scope all settings #1629
Conversation
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
plemarquand
force-pushed
the
scope-settings
branch
2 times, most recently
from
8c9acee to
30e32a7
Compare
| @@ -782,7 +803,8 @@ | |||
| "Never automatically update CodeLLDB settings when they are incorrect." | |||
| ], | |||
| "markdownDescription": "Choose how CodeLLDB settings are updated when debugging Swift executables.", | |||
| "order": 3 | |||
| "order": 3, | |||
| "scope": "machine-overridable" | |||
There was a problem hiding this comment.
I think the CodeLLDB settings should be per project because its possible some projects may work better with one debugger over the other.
| @@ -782,7 +803,8 @@ | |||
| "Never automatically update CodeLLDB settings when they are incorrect." | |||
| ], | |||
| "markdownDescription": "Choose how CodeLLDB settings are updated when debugging Swift executables.", | |||
| "order": 3 | |||
| "order": 3, | |||
| "scope": "machine-overridable" | |||
| }, | |||
| "swift.debugger.useDebugAdapterFromToolchain": { | |||
|
@plemarquand is their any repercussion if one of the settings we're changing to |
|
@award999 Good point, there is a risk that some of the ones being set to "application" will no longer take effect if they're set in a settings.json for a project. A list of the ones that are now application are:
None of these would break a project if they were ignored on a per-project basis, but it might be a bit confusing if they stopped working as they did before. |
Be more explicit about settings scopes, marking appropriate ones as `application` (user settings applied across all swift projects) and `machine-overridable` (for per-project settings).
plemarquand
force-pushed
the
scope-settings
branch
from
fd43c93 to
44e9833
Compare
|
@plemarquand I think those are low risk settings. Will point it out in release notes and message but I'm not concerned |
github-project-automation
bot
moved this from Next
to Needs Verification
in Swift Extension for Visual Studio Code
|
Verified with 323d996 |
matthewbastien
moved this from Needs Verification
to Done
in Swift Extension for Visual Studio Code
Be more explicit about settings scopes, marking appropriate ones as
application(user settings applied across all swift projects) andmachine-overridable(for per-project settings).