Skip to content

ICU: tweak build rules slightly #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2024
Merged

ICU: tweak build rules slightly #279

merged 1 commit into from
May 2, 2024

Conversation

compnerd
Copy link
Member

  • Emit the stub data library into a subdirectory to prevent collisions
  • Remove the generated output from byproducts, it is the output

@compnerd
ICU: tweak build rules slightly
1a41cd9 
- Emit the stub data library into a subdirectory to prevent collisions
- Remove the generated output from byproducts, it is the output
@compnerd compnerd requested a review from etcwilde February 23, 2024 16:45
@compnerd compnerd mentioned this pull request Feb 23, 2024
Draft
@compnerd
Copy link
Member Author

Tested at https://ci-external.swift.org/job/swift-PR-windows/22082/

@compnerd compnerd requested a review from hyp February 28, 2024 16:20
hyp
hyp approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@hyp hyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@compnerd compnerd merged commit db85319 into swiftlang:main May 2, 2024
@compnerd compnerd deleted the icu branch May 2, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyp hyp hyp approved these changes

@shahmishal shahmishal Awaiting requested review from shahmishal shahmishal is a code owner

@tomerd tomerd Awaiting requested review from tomerd

@etcwilde etcwilde Awaiting requested review from etcwilde etcwilde is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@compnerd @hyp