Remove the unsuitable test case

Also apply suggestions from code review.

Author: hironytic

Sources/SwiftDocC/Model/Rendering/RenderContentCompiler.swift

@@ -46,11 +46,7 @@ struct RenderContentCompiler: MarkupVisitor {
     }
 
     mutating func visitHeading(_ heading: Heading) -> [RenderContent] {
-        let fragment = urlReadableFragment(heading.plainText)
-        var components = URLComponents()
-        components.fragment = fragment
-        let anchor = components.url?.fragment ?? fragment
-        return [RenderBlockContent.heading(.init(level: heading.level, text: heading.plainText, anchor: anchor))]
+        return [RenderBlockContent.heading(.init(level: heading.level, text: heading.plainText, anchor: urlReadableFragment(heading.plainText).addingPercentEncoding(withAllowedCharacters: .urlFragmentAllowed)))]
     }
 
     mutating func visitListItem(_ listItem: ListItem) -> [RenderContent] {

Tests/SwiftDocCTests/Infrastructure/NodeURLGeneratorTests.swift

@@ -77,19 +77,6 @@ class NodeURLGeneratorTests: XCTestCase {
         XCTAssertEqual(generator.urlForReference(classIdentifier).absoluteString, "file:///path/to/bundle/_testbundle-ctlj/products/documentation.builtbundle/com.example.testbundle/data/folder/_privateclass/_privatesubclass")
     }
 
-    func testsafeURLWithEncodableFragment() throws {
-        // This is a realist DerivedData folder.
-        let baseURL = URL(string: "file:///path/to/bundle/_testbundle-ctlj/products/documentation.builtbundle/com.example.testbundle/data/")!
-        let generator = NodeURLGenerator(baseURL: baseURL)
-        
-        let basicIdentifier = ResolvedTopicReference(bundleIdentifier: "com.example.testbundle",
-                                                     path: "/folder/class/symbol",
-                                                     fragment: "テスト", // Non-ASCII; E3 83 86 E3 82 B9 E3 83 88 in UTF-8
-                                                     sourceLanguage: .swift)
-        
-        XCTAssertEqual(generator.urlForReference(basicIdentifier).absoluteString, "file:///path/to/bundle/_testbundle-ctlj/products/documentation.builtbundle/com.example.testbundle/data/folder/class/symbol#%E3%83%86%E3%82%B9%E3%83%88")
-    }
-    
     var inputLongPaths = [
         // Paths within the limits
         "/path/to/symbol.json",

Tests/SwiftDocCTests/Model/RenderContentMetadataTests.swift

@@ -304,8 +304,6 @@ class RenderContentMetadataTests: XCTestCase {
 
         let source = """
         ## テスト
-        
-        Note that テスト consists of Non-ASCII characters of E3 83 86 E3 82 B9 E3 83 88 in UTF-8.
         """
         let document = Document(parsing: source)
 
@@ -315,7 +313,7 @@ class RenderContentMetadataTests: XCTestCase {
         case .heading(let heading):
             XCTAssertEqual(heading.level, 2)
             XCTAssertEqual(heading.text, "テスト")
-            XCTAssertEqual(heading.anchor, "%E3%83%86%E3%82%B9%E3%83%88")
+            XCTAssertEqual(heading.anchor, "%E3%83%86%E3%82%B9%E3%83%88", "The UTF-8 representation of テスト is E3 83 86 E3 82 B9 E3 83 88")
         default: XCTFail("Unexpected element")
         }
     }