fix(es/compat): Add support for destructuring with BigInts (#9215)

magic-akari · web-flow · commit 2cc70287e0c5 · 2024-07-12T06:34:40.000Z
**Related issue:** - #9213
diff --git a/crates/swc/tests/fixture/issues-9xxx/9213/input/.swcrc b/crates/swc/tests/fixture/issues-9xxx/9213/input/.swcrc
@@ -0,0 +1,5 @@
+{
+    "jsc": {
+        "target": "es5"
+    }
+}
diff --git a/crates/swc/tests/fixture/issues-9xxx/9213/input/destruct-bigint.js b/crates/swc/tests/fixture/issues-9xxx/9213/input/destruct-bigint.js
@@ -0,0 +1 @@
+var { 9007199254740991n: it } = { 9007199254740991n: 1 };
diff --git a/crates/swc/tests/fixture/issues-9xxx/9213/output/destruct-bigint.js b/crates/swc/tests/fixture/issues-9xxx/9213/output/destruct-bigint.js
@@ -0,0 +1,3 @@
+var _ref = {
+    9007199254740991n: 1
+}, it = _ref[9007199254740991n];
diff --git a/crates/swc_ecma_compat_es2015/src/destructuring.rs b/crates/swc_ecma_compat_es2015/src/destructuring.rs
@@ -1205,7 +1205,7 @@ fn make_ref_ident_for_array(
 }
 
 fn make_ref_prop_expr(ref_ident: &Ident, prop: Box<Expr>, mut computed: bool) -> Expr {
-    computed |= matches!(*prop, Expr::Lit(Lit::Num(..)) | Expr::Lit(Lit::Str(..)));
+    computed |= !matches!(*prop, Expr::Ident(..));
 
     MemberExpr {
         span: DUMMY_SP,

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +{
 +    "jsc": {
 +        "target": "es5"
 +    }
 +}
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+var { 9007199254740991n: it } = { 9007199254740991n: 1 };`
Original file line number	Diff line number	Diff line change
`@@ -1205,7 +1205,7 @@ fn make_ref_ident_for_array(`
`1205`	`1205`	`}`
`1206`	`1206`
`1207`	`1207`	`fn make_ref_prop_expr(ref_ident: &Ident, prop: Box<Expr>, mut computed: bool) -> Expr {`
`1208`		`- computed \|= matches!(*prop, Expr::Lit(Lit::Num(..)) \| Expr::Lit(Lit::Str(..)));`
	`1208`	`+ computed \|= !matches!(*prop, Expr::Ident(..));`
`1209`	`1209`
`1210`	`1210`	`MemberExpr {`
`1211`	`1211`	`span: DUMMY_SP,`