refactor(es/renamer): Inline get_unresolved (#10493)

Author: bvanjoi

.changeset/thick-kids-listen.md

@@ -0,0 +1,6 @@
+---
+swc_core: patch
+swc_ecma_transforms_base: patch
+---
+
+refactor(es/transform): inline get_unresolved

crates/swc_ecma_transforms_base/src/rename/mod.rs

@@ -110,19 +110,6 @@ impl<R> RenamePass<R>
 where
     R: Renamer,
 {
-    fn get_unresolved<N>(&self, n: &N, has_eval: bool) -> FxHashSet<Atom>
-    where
-        N: VisitWith<Collector<Id>>,
-    {
-        let (usages, decls, preserved) = collect(n, has_eval.then_some(self.config.top_level_mark));
-        usages
-            .into_iter()
-            .filter(|used_id| !decls.contains(used_id))
-            .map(|v| v.0)
-            .chain(preserved.into_iter().map(|v| v.0))
-            .collect()
-    }
-
     fn get_map<N>(&mut self, node: &N, skip_one: bool, top_level: bool, has_eval: bool) -> RenameMap
     where
         N: VisitWith<Collector<Id>> + VisitWith<Analyzer>,
@@ -143,13 +130,21 @@ where
         };
         scope.prepare_renaming();
 
-        let mut map = RenameMap::default();
+        let (usages, decls, preserved) =
+            collect(node, has_eval.then_some(self.config.top_level_mark));
+        let unresolved = usages
+            .into_iter()
+            .filter(|used_id| !decls.contains(used_id))
+            .map(|v| v.0)
+            .chain(preserved.into_iter().map(|v| v.0))
+            .collect::<FxHashSet<_>>();
 
         let mut unresolved = if !top_level {
-            let mut unresolved = self.unresolved.clone();
-            unresolved.extend(self.get_unresolved(node, has_eval));
-            Cow::Owned(unresolved)
+            let mut set = self.unresolved.clone();
+            set.extend(unresolved);
+            Cow::Owned(set)
         } else {
+            self.unresolved = unresolved;
             Cow::Borrowed(&self.unresolved)
         };
 
@@ -167,6 +162,8 @@ where
             }
         }
 
+        let mut map = RenameMap::default();
+
         if R::MANGLE {
             let cost = scope.rename_cost();
             scope.rename_in_mangle_mode(
@@ -335,8 +332,6 @@ where
 
         let has_eval = !self.config.ignore_eval && contains_eval(m, true);
 
-        self.unresolved = self.get_unresolved(m, has_eval);
-
         let map = self.get_map(m, false, true, has_eval);
 
         // If we have eval, we cannot rename a whole program at once.
@@ -378,8 +373,6 @@ where
 
         let has_eval = !self.config.ignore_eval && contains_eval(m, true);
 
-        self.unresolved = self.get_unresolved(m, has_eval);
-
         let map = self.get_map(m, false, true, has_eval);
 
         if has_eval {