Fix error decoding #169
Merged
Fix error decoding #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes a small bug when decoding API errors in the GoTrue package.
What is the current behavior?
The current
keyDecodingStrategyused by the GoTrue package already decodes from snake case to camel case, however coding keys were explicitly set, leading to an error message with missing information. I came across this when trying out Supabase for the first time and receiving an error about an unconfirmed email address, it was impossible to debug this without running a network proxy and inspecting the response.What is the new behavior?
Removes codingKeys from
GoTrueError.APIErroras this is covered already bykeyDecodingStrategyand was causing issues.