Skip to content

Conversation

nyannyacha
Copy link
Contributor

What kind of change does this PR introduce?

Chore, Enhancement

Description

This PR includes the following changes

  • Added integration tests for commonjs
  • Added examples for commonjs
  • Added an integration test to check if importMap field in deno.json is recognized correctly
  • Makes the main field of package.json to be recognized

Closes FUNC-180
Closes FUNC-162

@nyannyacha nyannyacha requested a review from laktek February 26, 2025 04:40
@nyannyacha nyannyacha enabled auto-merge (squash) February 26, 2025 04:40
@laktek
Copy link
Contributor

laktek commented Feb 26, 2025

Do we also support files with .cjs extension? https://docs.deno.com/runtime/fundamentals/node/#use-.cjs-extension If so, good to add a test case for it too.

@nyannyacha nyannyacha merged commit d32a041 into supabase:develop Feb 26, 2025
4 checks passed
Copy link

🎉 This PR is included in version 1.68.0-develop.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@nyannyacha
Copy link
Contributor Author

@nyannyacha nyannyacha deleted the fix-add-commonjs-integration-tests branch February 26, 2025 04:54
@nyannyacha nyannyacha added this to the Deno 2.1 LTS milestone Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants