Skip to content

feat: remove solana dependency by inlining types #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025

Conversation

hf
Copy link
Contributor

@hf hf commented Jul 9, 2025

Bundlers are having a hard time with this dependency, and we don't want to directly depend on runtime code from the Solana / Wallet Standard libraries (due to supply chain attacks) so the relevant types are copied over.

Fixes #1076.

@hf hf force-pushed the hf/remove-solana-dependency branch from 7989468 to 0cf76f3 Compare July 9, 2025 09:01
@hf hf merged commit 7665f94 into master Jul 9, 2025
7 checks passed
@hf hf deleted the hf/remove-solana-dependency branch July 9, 2025 09:09
hf pushed a commit that referenced this pull request Jul 14, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.71.0](v2.70.0...v2.71.0)
(2025-07-10)


### Features

* fallback to `getUser()` if the `kid` of the JWT is not found
([#1080](#1080))
([9721f60](9721f60))
* introduce experimental split user and session storage
([#1023](#1023))
([e7b2f21](e7b2f21))
* make `getClaims()` non experimental, add global cache
([#1078](#1078))
([ffe13d7](ffe13d7))
* remove solana dependency by inlining types
([#1079](#1079))
([7665f94](7665f94))


### Bug Fixes

* handle null current session with split session storage
([#1071](#1071))
([bc6192a](bc6192a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript compilation fails: @solana/wallet-standard-features in wrong dependency section
2 participants