feat: add Sendable conformances and fix warnings (#260)

* feat: add Sendable conformances and fix warnings

* chore: add existential any

* chore: remove swift 5.10 from CI

* chore: add any on non-Darwin code

* fix library evolution

Author: grdsdev

.github/workflows/ci.yml

@@ -6,7 +6,7 @@ on:
       - main
   pull_request:
     branches:
-      - '*'
+      - "*"
   workflow_dispatch:
 
 concurrency:
@@ -37,41 +37,33 @@ jobs:
   library-linux:
     runs-on: ubuntu-latest
     name: Test Library (Linux)
+    strategy:
+      matrix:
+        swift-version: ["5.8", "5.9"]
     steps:
       - uses: swift-actions/setup-swift@v1
         with:
-          swift-version: "5.9"
+          swift-version: "${{ matrix.swift-version }}"
       - uses: actions/checkout@v3
       - name: Run Tests
         run: swift test
 
-  library-compatibility:
-    runs-on: ubuntu-latest
-    name: Test Library (Swift 5.8)
+  library-windows:
+    runs-on: windows-latest
+    name: Test Library (Windows)
     steps:
-      - uses: swift-actions/setup-swift@v1
+      # We use BCNY's repo since they have newer builds of Swift
+      # which have fixed libcurl in Foundation.
+      - uses: compnerd/gha-setup-swift@main
         with:
-          swift-version: "5.8"
+          release-tag-name: "20231203.0"
+          github-repo: "thebrowsercompany/swift-build"
+          release-asset-name: installer-amd64.exe
+          github-token: ${{ secrets.GITHUB_TOKEN }}
       - uses: actions/checkout@v3
       - name: Run Tests
         run: swift test
 
-  library-windows:
-      runs-on: windows-latest
-      name: Test Library (Windows)
-      steps:
-        # We use BCNY's repo since they have newer builds of Swift
-        # which have fixed libcurl in Foundation.
-        - uses: compnerd/gha-setup-swift@main
-          with:
-            release-tag-name: "20231203.0"
-            github-repo: "thebrowsercompany/swift-build"
-            release-asset-name: installer-amd64.exe
-            github-token: ${{ secrets.GITHUB_TOKEN }}
-        - uses: actions/checkout@v3
-        - name: Run Tests
-          run: swift test
-
   examples:
     runs-on: macos-14
     name: Build Examples

Examples/Examples/Auth/GoogleSignInSDKFlow.swift

@@ -5,10 +5,10 @@
 //  Created by Guilherme Souza on 05/03/24.
 //
 
-import SwiftUI
 @preconcurrency import GoogleSignIn
 import GoogleSignInSwift
 import Supabase
+import SwiftUI
 
 @MainActor
 struct GoogleSignInSDKFlow: View {

Examples/Examples/ExamplesApp.swift

@@ -5,9 +5,9 @@
 //  Created by Guilherme Souza on 22/12/22.
 //
 
+import GoogleSignIn
 import Supabase
 import SwiftUI
-import GoogleSignIn
 
 @main
 struct ExamplesApp: App {

Package.swift

@@ -137,6 +137,7 @@ let package = Package(
 
 for target in package.targets where !target.isTest {
   target.swiftSettings = [
-    .enableUpcomingFeature("StrictConcurrency=complete"),
+    .enableUpcomingFeature("ExistentialAny"),
+    .enableExperimentalFeature("StrictConcurrency"),
   ]
 }

Sources/Auth/AuthClient.swift

@@ -16,8 +16,8 @@ public actor AuthClient {
     public let url: URL
     public var headers: [String: String]
     public let flowType: AuthFlowType
-    public let localStorage: AuthLocalStorage
-    public let logger: SupabaseLogger?
+    public let localStorage: any AuthLocalStorage
+    public let logger: (any SupabaseLogger)?
     public let encoder: JSONEncoder
     public let decoder: JSONDecoder
     public let fetch: FetchHandler
@@ -37,8 +37,8 @@ public actor AuthClient {
       url: URL,
       headers: [String: String] = [:],
       flowType: AuthFlowType = Configuration.defaultFlowType,
-      localStorage: AuthLocalStorage,
-      logger: SupabaseLogger? = nil,
+      localStorage: any AuthLocalStorage,
+      logger: (any SupabaseLogger)? = nil,
       encoder: JSONEncoder = AuthClient.Configuration.jsonEncoder,
       decoder: JSONDecoder = AuthClient.Configuration.jsonDecoder,
       fetch: @escaping FetchHandler = { try await URLSession.shared.data(for: $0) }
@@ -64,23 +64,23 @@ public actor AuthClient {
     Dependencies.current.value!.api
   }
 
-  private var sessionManager: SessionManager {
+  private var sessionManager: any SessionManager {
     Dependencies.current.value!.sessionManager
   }
 
   private var codeVerifierStorage: CodeVerifierStorage {
     Dependencies.current.value!.codeVerifierStorage
   }
 
-  private var eventEmitter: EventEmitter {
+  private var eventEmitter: any EventEmitter {
     Dependencies.current.value!.eventEmitter
   }
 
   private var currentDate: @Sendable () -> Date {
     Dependencies.current.value!.currentDate
   }
 
-  private var logger: SupabaseLogger? {
+  private var logger: (any SupabaseLogger)? {
     Dependencies.current.value!.logger
   }
 
@@ -116,8 +116,8 @@ public actor AuthClient {
     url: URL,
     headers: [String: String] = [:],
     flowType: AuthFlowType = AuthClient.Configuration.defaultFlowType,
-    localStorage: AuthLocalStorage,
-    logger: SupabaseLogger? = nil,
+    localStorage: any AuthLocalStorage,
+    logger: (any SupabaseLogger)? = nil,
     encoder: JSONEncoder = AuthClient.Configuration.jsonEncoder,
     decoder: JSONDecoder = AuthClient.Configuration.jsonDecoder,
     fetch: @escaping FetchHandler = { try await URLSession.shared.data(for: $0) }
@@ -160,12 +160,12 @@ public actor AuthClient {
   /// This internal initializer is here only for easy injecting mock instances when testing.
   init(
     configuration: Configuration,
-    sessionManager: SessionManager,
+    sessionManager: any SessionManager,
     codeVerifierStorage: CodeVerifierStorage,
     api: APIClient,
-    eventEmitter: EventEmitter,
+    eventEmitter: any EventEmitter,
     sessionStorage: SessionStorage,
-    logger: SupabaseLogger?
+    logger: (any SupabaseLogger)?
   ) {
     mfa = AuthMFA()
     admin = AuthAdmin()
@@ -198,7 +198,7 @@ public actor AuthClient {
   @discardableResult
   public func onAuthStateChange(
     _ listener: @escaping AuthStateChangeListener
-  ) async -> AuthStateChangeListenerRegistration {
+  ) async -> some AuthStateChangeListenerRegistration {
     let handle = eventEmitter.attachListener(listener)
     await emitInitialSession(forHandle: handle)
     return handle

Sources/Auth/AuthMFA.swift

@@ -7,15 +7,15 @@ public actor AuthMFA {
     Dependencies.current.value!.api
   }
 
-  private var sessionManager: SessionManager {
+  private var sessionManager: any SessionManager {
     Dependencies.current.value!.sessionManager
   }
 
   private var configuration: AuthClient.Configuration {
     Dependencies.current.value!.configuration
   }
 
-  private var eventEmitter: EventEmitter {
+  private var eventEmitter: any EventEmitter {
     Dependencies.current.value!.eventEmitter
   }
 

Sources/Auth/Deprecated.swift

@@ -71,7 +71,7 @@ extension AuthClient.Configuration {
     url: URL,
     headers: [String: String] = [:],
     flowType: AuthFlowType = Self.defaultFlowType,
-    localStorage: AuthLocalStorage,
+    localStorage: any AuthLocalStorage,
     encoder: JSONEncoder = AuthClient.Configuration.jsonEncoder,
     decoder: JSONDecoder = AuthClient.Configuration.jsonDecoder,
     fetch: @escaping AuthClient.FetchHandler = { try await URLSession.shared.data(for: $0) }
@@ -109,7 +109,7 @@ extension AuthClient {
     url: URL,
     headers: [String: String] = [:],
     flowType: AuthFlowType = Configuration.defaultFlowType,
-    localStorage: AuthLocalStorage,
+    localStorage: any AuthLocalStorage,
     encoder: JSONEncoder = AuthClient.Configuration.jsonEncoder,
     decoder: JSONDecoder = AuthClient.Configuration.jsonDecoder,
     fetch: @escaping AuthClient.FetchHandler = { try await URLSession.shared.data(for: $0) }

Sources/Auth/Internal/CodeVerifierStorage.swift

@@ -9,7 +9,7 @@ struct CodeVerifierStorage: Sendable {
 
 extension CodeVerifierStorage {
   static var live: Self = {
-    var localStorage: AuthLocalStorage {
+    var localStorage: any AuthLocalStorage {
       Dependencies.current.value!.configuration.localStorage
     }
 

Sources/Auth/Internal/Dependencies.swift

@@ -6,12 +6,12 @@ struct Dependencies: Sendable {
   static let current = LockIsolated(Dependencies?.none)
 
   var configuration: AuthClient.Configuration
-  var sessionManager: SessionManager
+  var sessionManager: any SessionManager
   var api: APIClient
-  var eventEmitter: EventEmitter
+  var eventEmitter: any EventEmitter
   var sessionStorage: SessionStorage
   var sessionRefresher: SessionRefresher
   var codeVerifierStorage: CodeVerifierStorage
   var currentDate: @Sendable () -> Date = { Date() }
-  var logger: SupabaseLogger?
+  var logger: (any SupabaseLogger)?
 }

Sources/Auth/Internal/SessionManager.swift

@@ -22,7 +22,7 @@ actor DefaultSessionManager: SessionManager {
 
   private init() {}
 
-  private var task: Task<Session, Error>?
+  private var task: Task<Session, any Error>?
 
   private var storage: SessionStorage {
     Dependencies.current.value!.sessionStorage