[Fix] notEqual and notDeepEqual show "expected" value on failure.#454
Merged
ljharb merged 1 commit intotape-testing:masterfrom Dec 28, 2018
Merged
[Fix] notEqual and notDeepEqual show "expected" value on failure.#454ljharb merged 1 commit intotape-testing:masterfrom
ljharb merged 1 commit intotape-testing:masterfrom
Conversation
ljharb
requested changes
Dec 22, 2018
Collaborator
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
It'd be great to include regression tests with this, so it doesn't break in the future.
Contributor
Author
|
OK, try this. But you had better check over my code: I just copied |
ljharb
approved these changes
Dec 28, 2018
Collaborator
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
This looks awesome, thanks!
ljharb
added a commit
that referenced
this pull request
Dec 29, 2018
- [Fix] notEqual and notDeepEqual show "expected" value on failure (#454) - [Docs] Updated readme to make test, test.only, and test.skip consistent (#452) - [Docs] Clarify doesNotThrow parameters (#450) - [Docs] Adding tap-junit (#449) - [readme] Change broken image to use web archive (#443) - [Docs] convert list of tap reporters to links (#439, #440) - [Dev Deps] update `eslint`, `eclint`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #453.