Skip to content

Commit 0fdae42

Browse files
committed
fix: post merge
1 parent 11b5eda commit 0fdae42

File tree

8 files changed

+95
-233
lines changed

8 files changed

+95
-233
lines changed

package-lock.json

Lines changed: 70 additions & 170 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/driver/spanner/SpannerDriver.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,10 @@ export class SpannerDriver implements Driver {
210210
*/
211211
async connect(): Promise<void> {
212212
this.instance = this.spanner.instance(this.options.instanceId)
213-
this.instanceDatabase = this.instance.database(this.options.databaseId, this.options.sessionPool ?? {})
213+
this.instanceDatabase = this.instance.database(
214+
this.options.databaseId,
215+
this.options.sessionPool ?? {},
216+
)
214217
}
215218

216219
/**

src/driver/spanner/SpannerSessionPoolOptions.ts

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,22 @@
33
* more: https://github.com/ko3a4ok/nodejs-spanner/blob/aa8e8becf74d41d0de68253c17ebab188b5c7620/src/session-pool.ts#L149
44
*/
55
export interface SpannerSessionPoolOptions {
6-
acquireTimeout?: number;
7-
concurrency?: number;
8-
fail?: boolean;
9-
idlesAfter?: number;
10-
keepAlive?: number;
11-
labels?: { [label: string]: string };
12-
max?: number;
13-
maxIdle?: number;
14-
min?: number;
6+
acquireTimeout?: number
7+
concurrency?: number
8+
fail?: boolean
9+
idlesAfter?: number
10+
keepAlive?: number
11+
labels?: { [label: string]: string }
12+
max?: number
13+
maxIdle?: number
14+
min?: number
1515
/**
1616
* @deprecated. Starting from v6.5.0 the same session can be reused for
1717
* different types of transactions.
1818
*/
19-
writes?: number;
20-
incStep?: number;
21-
databaseRole?: string | null;
19+
writes?: number
20+
incStep?: number
21+
databaseRole?: string | null
2222
}
2323
/* Defaults:
2424
const DEFAULTS: SessionPoolOptions = {

src/entity-manager/MongoEntityManager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1097,7 +1097,7 @@ export class MongoEntityManager extends EntityManager {
10971097
) || {}
10981098
if (id) {
10991099
query["_id"] =
1100-
id instanceof objectIdInstance ? id : new ObjectId(id)
1100+
id instanceof objectIdInstance ? id : new objectIdInstance(id)
11011101
}
11021102
const cursor = this.createEntityCursor<Entity>(entityClassOrName, query)
11031103
const deleteDateColumn =

src/migration/MigrationExecutor.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -517,9 +517,11 @@ export class MigrationExecutor {
517517
.migrationId,
518518
}),
519519
isGenerated: true,
520-
generationStrategy: this.connection.driver.options.type === "spanner"
521-
? "uuid"
522-
: "increment",
520+
generationStrategy:
521+
this.connection.driver.options.type ===
522+
"spanner"
523+
? "uuid"
524+
: "increment",
523525
isPrimary: true,
524526
isNullable: false,
525527
},
@@ -670,7 +672,7 @@ export class MigrationExecutor {
670672
values["name"] = migration.name
671673
}
672674

673-
if(this.connection.driver.options.type === "spanner"){
675+
if (this.connection.driver.options.type === "spanner") {
674676
// Spanner cannot auto-generate the id, so we need to provide it
675677
values["id"] = uuidv4()
676678
}

src/persistence/SubjectExecutor.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -525,7 +525,8 @@ export class SubjectExecutor {
525525
* Updates all given subjects in the database.
526526
*/
527527
protected async executeUpdateOperations(): Promise<void> {
528-
const isSpanner = this.queryRunner.connection.driver.options.type === "spanner"
528+
const isSpanner =
529+
this.queryRunner.connection.driver.options.type === "spanner"
529530
const updateSubject = async (subject: Subject) => {
530531
if (!subject.identifier)
531532
throw new SubjectWithoutIdentifierError(subject)

src/query-builder/QueryBuilder.ts

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -837,20 +837,6 @@ export abstract class QueryBuilder<Entity extends ObjectLiteral> {
837837
return ""
838838
}
839839

840-
/**
841-
* Time travel queries for CockroachDB
842-
*/
843-
protected createTimeTravelQuery(): string {
844-
if (
845-
this.expressionMap.queryType === "select" &&
846-
this.expressionMap.timeTravel
847-
) {
848-
return ` AS OF SYSTEM TIME ${this.expressionMap.timeTravel}`
849-
}
850-
851-
return ""
852-
}
853-
854840
/**
855841
* Creates "WHERE" expression.
856842
*/

test/functional/naming-strategy/legacy-oracle-naming-strategy/create-table/create-table.ts

Lines changed: 0 additions & 30 deletions
This file was deleted.

0 commit comments

Comments
 (0)