Skip to content

Commit 3e4ccc6

Browse files
Copilotstreamich
andcommitted
fix: make position parameter optional in readvSync, writeSync, and writevSync methods
Co-authored-by: streamich <[email protected]>
1 parent cee39fe commit 3e4ccc6

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/node/volume.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -378,9 +378,9 @@ export class Volume implements FsCallbackApi, FsSynchronousApi {
378378
});
379379
};
380380

381-
public readvSync = (fd: number, buffers: ArrayBufferView[], position: number | null): number => {
381+
public readvSync = (fd: number, buffers: ArrayBufferView[], position?: number | null): number => {
382382
validateFd(fd);
383-
return this._core.readv(fd, buffers, position);
383+
return this._core.readv(fd, buffers, position ?? null);
384384
};
385385

386386
private readonly _readfile = (id: TFileId, flagsNum: number, encoding: BufferEncoding): Buffer | string => {
@@ -438,7 +438,7 @@ export class Volume implements FsCallbackApi, FsSynchronousApi {
438438
buffer: Buffer | ArrayBufferView | DataView,
439439
offset?: number,
440440
length?: number,
441-
position?: number,
441+
position?: number | null,
442442
): number;
443443
(fd: number, str: string, position?: number, encoding?: BufferEncoding): number;
444444
} = (
@@ -524,9 +524,9 @@ export class Volume implements FsCallbackApi, FsSynchronousApi {
524524
});
525525
};
526526

527-
public writevSync = (fd: number, buffers: ArrayBufferView[], position: number | null): number => {
527+
public writevSync = (fd: number, buffers: ArrayBufferView[], position?: number | null): void => {
528528
validateFd(fd);
529-
return this.writevBase(fd, buffers, position);
529+
this.writevBase(fd, buffers, position ?? null);
530530
};
531531

532532
public writeFileSync = (id: TFileId, data: TData, options?: opts.IWriteFileOptions): void => {

0 commit comments

Comments
 (0)