scatterlist: sg_set_buf() argument must be in linear mapping

rustyrussell · axboe · commit ac4e97abce9b · 2013-05-30T09:20:20.000+02:00
Add a check behind CONFIG_DEBUG_SG to verify this.

Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
Signed-off-by: Jens Axboe &lt;axboe@kernel.dk&gt;
diff --git a/include/linux/scatterlist.h b/include/linux/scatterlist.h
@@ -111,6 +111,9 @@ static inline struct page *sg_page(struct scatterlist *sg)
 static inline void sg_set_buf(struct scatterlist *sg, const void *buf,
 			      unsigned int buflen)
 {
+#ifdef CONFIG_DEBUG_SG
+	BUG_ON(!virt_addr_valid(buf));
+#endif
 	sg_set_page(sg, virt_to_page(buf), buflen, offset_in_page(buf));
 }
 

Original file line number	Diff line number	Diff line change
`@@ -111,6 +111,9 @@ static inline struct page sg_page(struct scatterlist sg)`
`111`	`111`	`static inline void sg_set_buf(struct scatterlist sg, const void buf,`
`112`	`112`	`unsigned int buflen)`
`113`	`113`	`{`
	`114`	`+#ifdef CONFIG_DEBUG_SG`
	`115`	`+ BUG_ON(!virt_addr_valid(buf));`
	`116`	`+#endif`
`114`	`117`	`sg_set_page(sg, virt_to_page(buf), buflen, offset_in_page(buf));`
`115`	`118`	`}`
`116`	`119`