From 692afcb69e47de99d9675571503e6cc7a73dd1a7 Mon Sep 17 00:00:00 2001 From: Neeraj Pathak Date: Fri, 27 Dec 2024 14:30:14 +0530 Subject: [PATCH 1/8] refactor: update `stats/base/dnanmeanpn` native addon from C++ to C PR-URL: https://github.com/stdlib-js/stdlib/pull/4110 Reviewed-by: Athan Reines --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: passed - task: run_c_examples status: passed - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed --- --- .../stats/base/dnanmeanpn/include.gypi | 2 +- .../stats/base/dnanmeanpn/manifest.json | 39 +++++- .../@stdlib/stats/base/dnanmeanpn/src/addon.c | 43 +++++++ .../stats/base/dnanmeanpn/src/addon.cpp | 117 ------------------ 4 files changed, 82 insertions(+), 119 deletions(-) create mode 100644 lib/node_modules/@stdlib/stats/base/dnanmeanpn/src/addon.c delete mode 100644 lib/node_modules/@stdlib/stats/base/dnanmeanpn/src/addon.cpp diff --git a/lib/node_modules/@stdlib/stats/base/dnanmeanpn/include.gypi b/lib/node_modules/@stdlib/stats/base/dnanmeanpn/include.gypi index 868c5c12e852..26476a8c2655 100644 --- a/lib/node_modules/@stdlib/stats/base/dnanmeanpn/include.gypi +++ b/lib/node_modules/@stdlib/stats/base/dnanmeanpn/include.gypi @@ -36,7 +36,7 @@ # Source files: 'src_files': [ - '<(src_dir)/addon.cpp', + '<(src_dir)/addon.c', ' + +/** +* Receives JavaScript callback invocation data. +* +* @param env environment under which the function is invoked +* @param info callback data +* @return Node-API value +*/ +static napi_value addon( napi_env env, napi_callback_info info ) { + STDLIB_NAPI_ARGV( env, info, argv, argc, 3 ); + STDLIB_NAPI_ARGV_INT64( env, N, argv, 0 ); + STDLIB_NAPI_ARGV_INT64( env, stride, argv, 2 ); + STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, X, N, stride, argv, 1 ); + STDLIB_NAPI_CREATE_DOUBLE( env, stdlib_strided_dnanmeanpn( N, X, stride ), v ); + return v; +} + +STDLIB_NAPI_MODULE_EXPORT_FCN( addon ) diff --git a/lib/node_modules/@stdlib/stats/base/dnanmeanpn/src/addon.cpp b/lib/node_modules/@stdlib/stats/base/dnanmeanpn/src/addon.cpp deleted file mode 100644 index 8c46b762906b..000000000000 --- a/lib/node_modules/@stdlib/stats/base/dnanmeanpn/src/addon.cpp +++ /dev/null @@ -1,117 +0,0 @@ -/** -* @license Apache-2.0 -* -* Copyright (c) 2020 The Stdlib Authors. -* -* Licensed under the Apache License, Version 2.0 (the "License"); -* you may not use this file except in compliance with the License. -* You may obtain a copy of the License at -* -* http://www.apache.org/licenses/LICENSE-2.0 -* -* Unless required by applicable law or agreed to in writing, software -* distributed under the License is distributed on an "AS IS" BASIS, -* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -* See the License for the specific language governing permissions and -* limitations under the License. -*/ - -#include "stdlib/stats/base/dnanmeanpn.h" -#include -#include -#include -#include -#include - -/** -* Add-on namespace. -*/ -namespace stdlib_stats_base_dnanmeanpn { - - /** - * Computes the arithmetic mean of a double-precision floating-point strided array, ignoring `NaN` values and using a two-pass error correction algorithm. - * - * ## Notes - * - * - When called from JavaScript, the function expects three arguments: - * - * - `N`: number of indexed elements - * - `X`: input array - * - `stride`: stride length - */ - napi_value node_dnanmeanpn( napi_env env, napi_callback_info info ) { - napi_status status; - - size_t argc = 3; - napi_value argv[ 3 ]; - status = napi_get_cb_info( env, info, &argc, argv, nullptr, nullptr ); - assert( status == napi_ok ); - - if ( argc < 3 ) { - napi_throw_error( env, nullptr, "invalid invocation. Must provide 3 arguments." ); - return nullptr; - } - - napi_valuetype vtype0; - status = napi_typeof( env, argv[ 0 ], &vtype0 ); - assert( status == napi_ok ); - if ( vtype0 != napi_number ) { - napi_throw_type_error( env, nullptr, "invalid argument. First argument must be a number." ); - return nullptr; - } - - bool res; - status = napi_is_typedarray( env, argv[ 1 ], &res ); - assert( status == napi_ok ); - if ( res == false ) { - napi_throw_type_error( env, nullptr, "invalid argument. Second argument must be a Float64Array." ); - return nullptr; - } - - napi_valuetype vtype2; - status = napi_typeof( env, argv[ 2 ], &vtype2 ); - assert( status == napi_ok ); - if ( vtype2 != napi_number ) { - napi_throw_type_error( env, nullptr, "invalid argument. Third argument must be a number." ); - return nullptr; - } - - int64_t N; - status = napi_get_value_int64( env, argv[ 0 ], &N ); - assert( status == napi_ok ); - - int64_t stride; - status = napi_get_value_int64( env, argv[ 2 ], &stride ); - assert( status == napi_ok ); - - napi_typedarray_type vtype1; - size_t xlen; - void *X; - status = napi_get_typedarray_info( env, argv[ 1 ], &vtype1, &xlen, &X, nullptr, nullptr ); - assert( status == napi_ok ); - if ( vtype1 != napi_float64_array ) { - napi_throw_type_error( env, nullptr, "invalid argument. Second argument must be a Float64Array." ); - return nullptr; - } - if ( (N-1)*llabs(stride) >= (int64_t)xlen ) { - napi_throw_range_error( env, nullptr, "invalid argument. Second argument has insufficient elements based on the associated stride and the number of indexed elements." ); - return nullptr; - } - - napi_value v; - status = napi_create_double( env, stdlib_strided_dnanmeanpn( N, (double *)X, stride ), &v ); - assert( status == napi_ok ); - - return v; - } - - napi_value Init( napi_env env, napi_value exports ) { - napi_status status; - napi_value fcn; - status = napi_create_function( env, "exports", NAPI_AUTO_LENGTH, node_dnanmeanpn, NULL, &fcn ); - assert( status == napi_ok ); - return fcn; - } - - NAPI_MODULE( NODE_GYP_MODULE_NAME, Init ) -} // end namespace stdlib_stats_base_dnanmeanpn From 6747262c7423a86593b86f89b2c82797384ddd35 Mon Sep 17 00:00:00 2001 From: JoyBoy <144602492+0PrashantYadav0@users.noreply.github.com> Date: Tue, 31 Dec 2024 21:51:52 +0530 Subject: [PATCH 2/8] feat: add C implementation for binomail pmf --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na --- --- .../stats/base/dists/binomial/pmf/README.md | 107 +++++++ .../dists/binomial/pmf/benchmark/benchmark.js | 17 +- .../pmf/benchmark/benchmark.native.js | 74 +++++ .../dists/binomial/pmf/benchmark/c/Makefile | 146 +++++++++ .../binomial/pmf/benchmark/c/benchmark.c | 143 +++++++++ .../stats/base/dists/binomial/pmf/binding.gyp | 170 ++++++++++ .../dists/binomial/pmf/examples/c/Makefile | 146 +++++++++ .../dists/binomial/pmf/examples/c/example.c | 45 +++ .../base/dists/binomial/pmf/include.gypi | 53 ++++ .../stdlib/stats/base/dists/binomial/pmf.h | 38 +++ .../base/dists/binomial/pmf/lib/native.js | 88 +++++ .../base/dists/binomial/pmf/manifest.json | 96 ++++++ .../base/dists/binomial/pmf/package.json | 3 + .../base/dists/binomial/pmf/src/Makefile | 70 ++++ .../stats/base/dists/binomial/pmf/src/addon.c | 23 ++ .../stats/base/dists/binomial/pmf/src/main.c | 68 ++++ .../dists/binomial/pmf/test/test.native.js | 300 ++++++++++++++++++ 17 files changed, 1583 insertions(+), 4 deletions(-) create mode 100644 lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/benchmark/benchmark.native.js create mode 100644 lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/benchmark/c/Makefile create mode 100644 lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/benchmark/c/benchmark.c create mode 100644 lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/binding.gyp create mode 100644 lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/examples/c/Makefile create mode 100644 lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/examples/c/example.c create mode 100644 lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/include.gypi create mode 100644 lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/include/stdlib/stats/base/dists/binomial/pmf.h create mode 100644 lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/lib/native.js create mode 100644 lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/manifest.json create mode 100644 lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/src/Makefile create mode 100644 lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/src/addon.c create mode 100644 lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/src/main.c create mode 100644 lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/test/test.native.js diff --git a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/README.md b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/README.md index b4725a5d5719..0a06d92f8739 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/README.md +++ b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/README.md @@ -152,6 +152,113 @@ for ( i = 0; i < 10; i++ ) { + + +
+ +## C APIs + + + +
+ +
+ + + + + +
+ +### Usage + +```c +#include "stdlib/stats/base/dists/binomial/pmf.h" +``` + +#### stdlib_base_dists_binomial_pmf( x, n, p ) + +Returns the [probability mass function][pmf] (PMF) for a [binomial][binomial-distribution] distribution with number of trials `n` and success probability `p`. + +```c +double out = stdlib_base_dists_binomial_pmf( 3.0, 20, 0.2 ); +// returns ~0.205 +``` + +The function accepts the following arguments: + +- **x**: `[in] int` input value. +- **n**: `[in] int` number of trials. +- **p**: `[in] double` success probability. + +```c +double stdlib_base_dists_binomial_pmf( const double x, const double n, const double p ); +``` + +
+ + + + + +
+ +
+ + + + + +
+ +### Examples + +```c +#include "stdlib/stats/base/dists/binomial/pmf.h" +#include "stdlib/math/base/special/ceil.h" +#include +#include + +static double random_uniform( const double min, const double max ) { + double v = (double)rand() / ( (double)RAND_MAX + 1.0 ); + return min + ( v * (max - min) ); +} + +int main( void ) { + double n; + double p; + double x; + double y; + int i; + + for ( i = 0; i < 25; i++ ) { + n = stdlib_base_ceil( random_uniform( 0, 100 ) ); + p = random_uniform( 0, 1 ); + x = random_uniform( 0, 50 ); + y = stdlib_base_dists_binomial_pmf( x, n, p ); + printf( "x: %lf, n: %lf, p: %lf, P(X=x;n,p): %lf\n", x, n, p, y ); + } + + return 0; +} +``` + +
+ + + +
+ + + + + +
+ +
+ + + @@ -217,6 +217,7 @@ double stdlib_base_dists_binomial_pmf( const double x, const double n, const dou #include "stdlib/stats/base/dists/binomial/pmf.h" #include "stdlib/math/base/special/ceil.h" #include +#include #include static double random_uniform( const double min, const double max ) { @@ -225,18 +226,18 @@ static double random_uniform( const double min, const double max ) { } int main( void ) { - double n; + int32_t n; double p; - double x; + int32_t x; double y; int i; for ( i = 0; i < 25; i++ ) { - n = stdlib_base_ceil( random_uniform( 0, 100 ) ); - p = random_uniform( 0, 1 ); - x = random_uniform( 0, 50 ); + n = stdlib_base_ceil( random_uniform( 0.0, 100.0 ) ); + p = random_uniform( 0.0, 1.0 ); + x = stdlib_base_ceil( random_uniform( 0.0, 50.0 ) ); y = stdlib_base_dists_binomial_pmf( x, n, p ); - printf( "x: %lf, n: %lf, p: %lf, P(X=x;n,p): %lf\n", x, n, p, y ); + printf( "x: %d, n: %d, p: %lf, P(X=x;n,p): %lf\n", x, n, p, y ); } return 0; diff --git a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/benchmark/benchmark.js b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/benchmark/benchmark.js index ced52d3fa653..2fa443626b9c 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/benchmark/benchmark.js @@ -21,6 +21,7 @@ // MODULES // var bench = require( '@stdlib/bench' ); +var Int32Array = require( '@stdlib/array/int32' ); var Float64Array = require( '@stdlib/array/float64' ); var ceil = require( '@stdlib/math/base/special/ceil' ); var randu = require( '@stdlib/random/base/randu' ); @@ -40,13 +41,13 @@ bench( pkg, function benchmark( b ) { var i; len = 100; - n = new Float64Array( len ); + n = new Int32Array( len ); p = new Float64Array( len ); - x = new Float64Array( len ); + x = new Int32Array( len ); for ( i = 0; i < len; i++ ) { n[ i ] = ceil( randu()*100.0 ); p[ i ] = randu(); - x[ i ] = randu()*50.0; + x[ i ] = ceil( randu()*50.0 ); } b.tic(); diff --git a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/benchmark/benchmark.native.js b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/benchmark/benchmark.native.js index 3e765a260546..f37b201ecd55 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/benchmark/benchmark.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/benchmark/benchmark.native.js @@ -22,6 +22,7 @@ var resolve = require( 'path' ).resolve; var bench = require( '@stdlib/bench' ); +var Int32Array = require( '@stdlib/array/int32' ); var Float64Array = require( '@stdlib/array/float64' ); var tryRequire = require( '@stdlib/utils/try-require' ); var ceil = require( '@stdlib/math/base/special/ceil' ); @@ -49,13 +50,13 @@ bench( pkg+'::native', opts, function benchmark( b ) { var i; len = 100; - n = new Float64Array( len ); + n = new Int32Array( len ); p = new Float64Array( len ); - x = new Float64Array( len ); + x = new Int32Array( len ); for ( i = 0; i < len; i++ ) { n[ i ] = ceil( randu()*100.0 ); p[ i ] = randu(); - x[ i ] = randu()*50.0; + x[ i ] = ceil( randu()*50.0 ); } b.tic(); diff --git a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/benchmark/c/benchmark.c b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/benchmark/c/benchmark.c index 945984f30546..acfdfae208e5 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/benchmark/c/benchmark.c +++ b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/benchmark/c/benchmark.c @@ -19,6 +19,7 @@ #include "stdlib/stats/base/dists/binomial/pmf.h" #include "stdlib/math/base/special/ceil.h" #include +#include #include #include #include @@ -94,17 +95,17 @@ static double random_uniform( const double min, const double max ) { */ static double benchmark( void ) { double elapsed; - double n[ 100 ]; + int32_t n[ 100 ]; double p[ 100 ]; - double x[ 100 ]; + int32_t x[ 100 ]; double y; double t; int i; for ( i = 0; i < 100; i++ ) { - n[ i ] = stdlib_base_ceil( random_uniform( 0, 100 ) ); - p[ i ] = random_uniform( 0, 1 ); - x[ i ] = random_uniform( 0, 50); + n[ i ] = stdlib_base_ceil( random_uniform( 0.0, 100.0 ) ); + p[ i ] = random_uniform( 0.0, 1.0 ); + x[ i ] = stdlib_base_ceil( random_uniform( 0.0, 50.0) ); } t = tic(); diff --git a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/examples/c/example.c b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/examples/c/example.c index d7624aad60fd..fd7d0b3b1b8a 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/examples/c/example.c +++ b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/examples/c/example.c @@ -19,6 +19,7 @@ #include "stdlib/stats/base/dists/binomial/pmf.h" #include "stdlib/math/base/special/ceil.h" #include +#include #include static double random_uniform( const double min, const double max ) { @@ -27,18 +28,18 @@ static double random_uniform( const double min, const double max ) { } int main( void ) { - double n; + int32_t n; double p; - double x; + int32_t x; double y; int i; for ( i = 0; i < 25; i++ ) { - n = stdlib_base_ceil( random_uniform( 0, 100 ) ); - p = random_uniform( 0, 1 ); - x = random_uniform( 0, 50 ); + n = stdlib_base_ceil( random_uniform( 0.0, 100.0 ) ); + p = random_uniform( 0.0, 1.0 ); + x = stdlib_base_ceil( random_uniform( 0.0, 50.0 ) ); y = stdlib_base_dists_binomial_pmf( x, n, p ); - printf( "x: %lf, n: %lf, p: %lf, P(X=x;n,p): %lf\n", x, n, p, y ); + printf( "x: %d, n: %d, p: %lf, P(X=x;n,p): %lf\n", x, n, p, y ); } return 0; diff --git a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/include/stdlib/stats/base/dists/binomial/pmf.h b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/include/stdlib/stats/base/dists/binomial/pmf.h index ac7182354914..daeb7566cfd8 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/include/stdlib/stats/base/dists/binomial/pmf.h +++ b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/include/stdlib/stats/base/dists/binomial/pmf.h @@ -27,9 +27,9 @@ extern "C" { #endif /** -* Returns the probability mass function (PMF) of a binomial distribution. +* Returns the probability mass function (PMF) for a binomial distribution with number of trials `n` and success probability `p` at a value `x`. */ -double stdlib_base_dists_binomial_pmf( const double x, const double n, const double p ); +double stdlib_base_dists_binomial_pmf( const int32_t x, const int32_t n, const double p ); #ifdef __cplusplus } diff --git a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/lib/native.js b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/lib/native.js index 52a46728c1f7..ce8766d3b793 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/lib/native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/lib/native.js @@ -51,22 +51,10 @@ var addon = require( './../src/addon.node' ); * // returns ~0.006 * * @example -* var y = pmf( NaN, 20, 0.5 ); -* // returns NaN -* -* @example -* var y = pmf( 0.0, NaN, 0.5 ); -* // returns NaN -* -* @example * var y = pmf( 0.0, 20, NaN ); * // returns NaN * * @example -* var y = pmf( 2.0, 1.5, 0.5 ); -* // returns NaN -* -* @example * var y = pmf( 2.0, -2.0, 0.5 ); * // returns NaN * diff --git a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/src/addon.c b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/src/addon.c index 24f1851ff831..f74c462427ae 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/src/addon.c +++ b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/src/addon.c @@ -20,4 +20,4 @@ #include "stdlib/math/base/napi/ternary.h" // cppcheck-suppress shadowFunction -STDLIB_MATH_BASE_NAPI_MODULE_DDD_D( stdlib_base_dists_binomial_pmf ); +STDLIB_MATH_BASE_NAPI_MODULE_IID_D( stdlib_base_dists_binomial_pmf ); diff --git a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/src/main.c b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/src/main.c index ae87e2efbc5f..9a3cce3e52a3 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/src/main.c +++ b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/src/main.c @@ -24,6 +24,7 @@ #include "stdlib/math/base/special/log1p.h" #include "stdlib/math/base/special/ln.h" #include "stdlib/math/base/special/exp.h" +#include /** * Evaluates the probability mass function (PMF) for a binomial distribution with number of trials `n` and success probability `p` at a value `x`. @@ -31,26 +32,22 @@ * @param x input value * @param n number of trials * @param p success probability -* @return evaluated logPMF +* @return evaluated PMF * * @example * double y = stdlib_base_dists_binomial_pmf( 3.0, 20, 0.2 ); * // returns ~0.205 */ -double stdlib_base_dists_binomial_pmf( const double x, const double n, const double p ) { +double stdlib_base_dists_binomial_pmf( const int32_t x, const int32_t n, const double p ) { if ( - stdlib_base_is_nan( x ) || - stdlib_base_is_nan( n ) || stdlib_base_is_nan( p ) || n < 0.0 || p < 0.0 || - p > 1.0 || - !stdlib_base_is_nonnegative_integer( n ) || - n == STDLIB_CONSTANT_FLOAT64_PINF + p > 1.0 ) { return 0.0 / 0.0; } - if ( stdlib_base_is_nonnegative_integer( x ) ){ + if ( x >= 0 ){ if ( x > n ) { return 0.0; } diff --git a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/test/test.native.js index d3bb5e021a52..706b7bf349e0 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/test/test.native.js @@ -55,18 +55,14 @@ tape( 'main export is a function', function test( t ) { }); tape( 'if provided `NaN` for any parameter, the function returns `NaN`', opts, function test( t ) { - var y = pmf( NaN, 20, 0.5 ); - t.equal( isnan( y ), true, 'returns NaN' ); - y = pmf( 0.0, NaN, 0.5 ); - t.equal( isnan( y ), true, 'returns NaN' ); + var y; y = pmf( 0.0, 20, NaN ); t.equal( isnan( y ), true, 'returns NaN' ); t.end(); }); tape( 'if provided a negative integer for `x` and a valid `n` and `p`, the function returns `0`', opts, function test( t ) { - var y = pmf( NINF, 20, 0.5 ); - t.equal( y, 0.0, 'returns 0' ); + var y; y = pmf( -20.0, 20, 0.5 ); t.equal( y, 0.0, 'returns 0' ); @@ -80,37 +76,12 @@ tape( 'if provided a negative integer for `x` and a valid `n` and `p`, the funct t.end(); }); -tape( 'if provided a non-integer for `x` and a valid `n` and `p`, the function returns `0`', opts, function test( t ) { - var y = pmf( -1.5, 20, 0.5 ); - t.equal( y, 0.0, 'returns 0' ); - - y = pmf( -0.5, 20, 0.5 ); - t.equal( y, 0.0, 'returns 0' ); - - y = pmf( 1.5, 20, 0.5 ); - t.equal( y, 0.0, 'returns 0' ); - - y = pmf( 2.5, 20, 0.5 ); - t.equal( y, 0.0, 'returns 0' ); - - t.end(); -}); - tape( 'if provided `n` which is not a nonnegative integer, the function returns `NaN`', opts, function test( t ) { var y; - y = pmf( 2.0, 1.5, 0.5 ); - t.equal( isnan( y ), true, 'returns NaN' ); - y = pmf( 0.0, -1.0, 0.5 ); t.equal( isnan( y ), true, 'returns NaN' ); - y = pmf( 2.0, NINF, 0.5 ); - t.equal( isnan( y ), true, 'returns NaN' ); - - y = pmf( 2.0, PINF, 0.5 ); - t.equal( isnan( y ), true, 'returns NaN' ); - t.end(); }); @@ -142,15 +113,6 @@ tape( 'if `p` or `n` equals `0`, the function evaluates a degenerate distributio y = pmf( 1.0, 8, 0.0 ); t.equal( y, 0.0, 'returns 0' ); - y = pmf( PINF, 8, 0.0 ); - t.equal( y, 0.0, 'returns 0' ); - - y = pmf( NINF, 8, 0.0 ); - t.equal( y, 0.0, 'returns 0' ); - - y = pmf( NaN, 8, 0.0 ); - t.equal( isnan( y ), true, 'returns NaN' ); - // Case: n = 0, p = 0.5 y = pmf( 0.0, 0, 0.5 ); t.equal( y, 1.0, 'returns 1 for x equal to 0' ); @@ -158,15 +120,6 @@ tape( 'if `p` or `n` equals `0`, the function evaluates a degenerate distributio y = pmf( 1.0, 0, 0.5 ); t.equal( y, 0.0, 'returns 0' ); - y = pmf( PINF, 0, 0.5 ); - t.equal( y, 0.0, 'returns 0' ); - - y = pmf( NINF, 0, 0.5 ); - t.equal( y, 0.0, 'returns 0' ); - - y = pmf( NaN, 0, 0.5 ); - t.equal( isnan( y ), true, 'returns NaN' ); - t.end(); }); @@ -179,15 +132,6 @@ tape( 'if `p` equals `1.0`, the function evaluates a degenerate distribution cen y = pmf( 1.0, 8, 1.0 ); t.equal( y, 0.0, 'returns 0' ); - y = pmf( PINF, 8, 1.0 ); - t.equal( y, 0.0, 'returns 0' ); - - y = pmf( NINF, 8, 1.0 ); - t.equal( y, 0.0, 'returns 0' ); - - y = pmf( NaN, 8, 1.0 ); - t.equal( isnan( y ), true, 'returns NaN' ); - t.end(); }); From 5cd516cd57d4e6e4d118f7f16bbed8910380168b Mon Sep 17 00:00:00 2001 From: JoyBoy <144602492+0PrashantYadav0@users.noreply.github.com> Date: Mon, 6 Jan 2025 20:41:41 +0530 Subject: [PATCH 5/8] chore: updated include statement --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: passed - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: failed --- --- .../binomial/pmf/include/stdlib/stats/base/dists/binomial/pmf.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/include/stdlib/stats/base/dists/binomial/pmf.h b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/include/stdlib/stats/base/dists/binomial/pmf.h index daeb7566cfd8..90e088a039f3 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/include/stdlib/stats/base/dists/binomial/pmf.h +++ b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/include/stdlib/stats/base/dists/binomial/pmf.h @@ -19,6 +19,8 @@ #ifndef STDLIB_STATS_BASE_DISTS_BINOMIAL_PMF_H #define STDLIB_STATS_BASE_DISTS_BINOMIAL_PMF_H +#include + /* * If C++, prevent name mangling so that the compiler emits a binary file having undecorated names, thus mirroring the behavior of a C compiler. */ From 0e2dee16c3577fd5a3746f7207565b292bf34325 Mon Sep 17 00:00:00 2001 From: JoyBoy <144602492+0PrashantYadav0@users.noreply.github.com> Date: Mon, 6 Jan 2025 21:01:51 +0530 Subject: [PATCH 6/8] chore: updated native tests --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: passed - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed --- --- .../@stdlib/stats/base/dists/binomial/pmf/test/test.native.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/test/test.native.js index 706b7bf349e0..a55ab5f9dc3f 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/test/test.native.js @@ -48,7 +48,7 @@ var highHigh = require( './fixtures/julia/high_high.json' ); // TESTS // -tape( 'main export is a function', function test( t ) { +tape( 'main export is a function', opts, function test( t ) { t.ok( true, __filename ); t.strictEqual( typeof pmf, 'function', 'main export is a function' ); t.end(); From 079cb48c6da4432b0c8c8e8a017bbaa348fabbac Mon Sep 17 00:00:00 2001 From: JoyBoy <144602492+0PrashantYadav0@users.noreply.github.com> Date: Mon, 6 Jan 2025 21:01:51 +0530 Subject: [PATCH 7/8] chore: updated native tests --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: passed - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na --- --- .../@stdlib/stats/base/dists/binomial/pmf/test/test.native.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/test/test.native.js index 706b7bf349e0..a55ab5f9dc3f 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/test/test.native.js @@ -48,7 +48,7 @@ var highHigh = require( './fixtures/julia/high_high.json' ); // TESTS // -tape( 'main export is a function', function test( t ) { +tape( 'main export is a function', opts, function test( t ) { t.ok( true, __filename ); t.strictEqual( typeof pmf, 'function', 'main export is a function' ); t.end(); From e6f0d5c188f8745921469eb5ee93cf122fd48e15 Mon Sep 17 00:00:00 2001 From: JoyBoy <144602492+0PrashantYadav0@users.noreply.github.com> Date: Mon, 6 Jan 2025 21:18:27 +0530 Subject: [PATCH 8/8] chore: removed unused includes --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na --- --- .../@stdlib/stats/base/dists/binomial/pmf/manifest.json | 3 --- .../@stdlib/stats/base/dists/binomial/pmf/src/main.c | 3 +-- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/manifest.json b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/manifest.json index 133ad643342d..d09739bbe823 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/manifest.json +++ b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/manifest.json @@ -41,7 +41,6 @@ "@stdlib/math/base/napi/ternary", "@stdlib/math/base/assert/is-nan", "@stdlib/constants/float64/pinf", - "@stdlib/math/base/assert/is-nonnegative-integer", "@stdlib/math/base/special/binomcoefln", "@stdlib/math/base/special/log1p", "@stdlib/math/base/special/ln", @@ -62,7 +61,6 @@ "dependencies": [ "@stdlib/math/base/assert/is-nan", "@stdlib/constants/float64/pinf", - "@stdlib/math/base/assert/is-nonnegative-integer", "@stdlib/math/base/special/binomcoefln", "@stdlib/math/base/special/log1p", "@stdlib/math/base/special/ln", @@ -84,7 +82,6 @@ "dependencies": [ "@stdlib/math/base/assert/is-nan", "@stdlib/constants/float64/pinf", - "@stdlib/math/base/assert/is-nonnegative-integer", "@stdlib/math/base/special/binomcoefln", "@stdlib/math/base/special/log1p", "@stdlib/math/base/special/ln", diff --git a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/src/main.c b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/src/main.c index 9a3cce3e52a3..b3a77dfbf12d 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/src/main.c +++ b/lib/node_modules/@stdlib/stats/base/dists/binomial/pmf/src/main.c @@ -19,7 +19,6 @@ #include "stdlib/stats/base/dists/binomial/pmf.h" #include "stdlib/math/base/assert/is_nan.h" #include "stdlib/constants/float64/pinf.h" -#include "stdlib/math/base/assert/is_nonnegative_integer.h" #include "stdlib/math/base/special/binomcoefln.h" #include "stdlib/math/base/special/log1p.h" #include "stdlib/math/base/special/ln.h" @@ -41,7 +40,7 @@ double stdlib_base_dists_binomial_pmf( const int32_t x, const int32_t n, const double p ) { if ( stdlib_base_is_nan( p ) || - n < 0.0 || + n < 0 || p < 0.0 || p > 1.0 ) {