Skip to content

Commit ab72ae8

Browse files
committed
EthJson Rpc flavor
1 parent de29dfc commit ab72ae8

File tree

4 files changed

+18
-19
lines changed

4 files changed

+18
-19
lines changed

beacon_chain/libnimbus_lc/libnimbus_lc.nim

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import
1515
eth/p2p/discoveryv5/random2,
1616
eth/rlp,
1717
eth/trie/ordered_trie,
18-
json_rpc/jsonmarshal,
1918
secp256k1,
2019
web3/[engine_api_types, eth_api_types, conversions],
2120
../el/engine_api_conversions,
@@ -1216,10 +1215,10 @@ proc ETHExecutionBlockHeaderCreateFromJson(
12161215
## See:
12171216
## * https://ethereum.org/en/developers/docs/apis/json-rpc/#eth_getblockbyhash
12181217
let data = try:
1219-
# a direct parameter like JrpcConv.decode($blockHeaderJson, BlockObject)
1218+
# a direct parameter like EthJson.decode($blockHeaderJson, BlockObject)
12201219
# will cause premature garbage collector kick in.
12211220
let jsonBytes = $blockHeaderJson
1222-
JrpcConv.decode(jsonBytes, BlockObject)
1221+
EthJson.decode(jsonBytes, BlockObject)
12231222
except SerializationError:
12241223
return nil
12251224
if data == nil:
@@ -1475,10 +1474,10 @@ proc ETHTransactionsCreateFromJson(
14751474
## See:
14761475
## * https://ethereum.org/en/developers/docs/apis/json-rpc/#eth_getblockbyhash
14771476
var datas = try:
1478-
# a direct parameter like JrpcConv.decode($transactionsJson, seq[TransactionObject])
1477+
# a direct parameter like EthJson.decode($transactionsJson, seq[TransactionObject])
14791478
# will cause premature garbage collector kick in.
14801479
let jsonBytes = $transactionsJson
1481-
JrpcConv.decode(jsonBytes, seq[TransactionObject])
1480+
EthJson.decode(jsonBytes, seq[TransactionObject])
14821481
except SerializationError:
14831482
return nil
14841483

@@ -2284,10 +2283,10 @@ proc ETHReceiptsCreateFromJson(
22842283
## See:
22852284
## * https://ethereum.org/en/developers/docs/apis/json-rpc/#eth_gettransactionreceipt
22862285
var datas = try:
2287-
# a direct parameter like JrpcConv.decode($receiptsJson, seq[ReceiptObject])
2286+
# a direct parameter like EthJson.decode($receiptsJson, seq[ReceiptObject])
22882287
# will cause premature garbage collector kick in.
22892288
let jsonBytes = $receiptsJson
2290-
JrpcConv.decode(jsonBytes, seq[ReceiptObject])
2289+
EthJson.decode(jsonBytes, seq[ReceiptObject])
22912290
except SerializationError:
22922291
return nil
22932292
if datas.len != ETHTransactionsGetCount(transactions):

ncli/ncli_testnet.nim

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import
1111
std/[json, options, times],
1212
chronos, bearssl/rand, chronicles, confutils, stint, json_serialization,
1313
web3, eth/common/keys, eth/p2p/discoveryv5/random2,
14-
stew/[io2, byteutils], json_rpc/jsonmarshal,
14+
stew/[io2, byteutils],
1515
../beacon_chain/conf,
1616
../beacon_chain/el/el_manager,
1717
../beacon_chain/networking/eth2_network,
@@ -399,7 +399,7 @@ proc doCreateTestnet*(config: CliConfig,
399399

400400
try:
401401
let blockAsJson = genesisBlockContents.get
402-
genesisBlock = JrpcConv.decode(blockAsJson, BlockObject)
402+
genesisBlock = EthJson.decode(blockAsJson, BlockObject)
403403
except CatchableError as err:
404404
error "Failed to load the genesis block from json",
405405
err = err.msg

research/fakeee.nim

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import
1919
proc setupEngineAPI*(server: RpcServer) =
2020
# https://github.com/ethereum/execution-apis/blob/v1.0.0-beta.4/src/engine/paris.md#engine_newpayloadv1
2121
# cannot use `params` as param name. see https:#github.com/status-im/nim-json-rpc/issues/128
22-
server.rpc("engine_newPayloadV1") do(payload: ExecutionPayloadV1) -> PayloadStatusV1:
22+
server.rpc("engine_newPayloadV1", EthJson) do(payload: ExecutionPayloadV1) -> PayloadStatusV1:
2323
info "engine_newPayloadV1",
2424
number = $(distinctBase payload.blockNumber), hash = payload.blockHash
2525

@@ -28,15 +28,15 @@ proc setupEngineAPI*(server: RpcServer) =
2828
)
2929

3030
# https://github.com/ethereum/execution-apis/blob/v1.0.0-beta.4/src/engine/shanghai.md#engine_newpayloadv2
31-
server.rpc("engine_newPayloadV2") do(payload: ExecutionPayloadV2) -> PayloadStatusV1:
31+
server.rpc("engine_newPayloadV2", EthJson) do(payload: ExecutionPayloadV2) -> PayloadStatusV1:
3232
info "engine_newPayloadV2", payload
3333

3434
return PayloadStatusV1(
3535
status: PayloadExecutionStatus.syncing,
3636
)
3737

3838
# https://github.com/ethereum/execution-apis/blob/v1.0.0-beta.4/src/engine/paris.md#engine_getpayloadv1
39-
server.rpc("engine_getPayloadV1") do(payloadId: Bytes8) -> ExecutionPayloadV1:
39+
server.rpc("engine_getPayloadV1", EthJson) do(payloadId: Bytes8) -> ExecutionPayloadV1:
4040
info "engine_getPayloadV1",
4141
id = payloadId.toHex
4242

@@ -46,7 +46,7 @@ proc setupEngineAPI*(server: RpcServer) =
4646
)
4747

4848
# https://github.com/ethereum/execution-apis/blob/v1.0.0-beta.4/src/engine/paris.md#engine_forkchoiceupdatedv1
49-
server.rpc("engine_forkchoiceUpdatedV1") do(
49+
server.rpc("engine_forkchoiceUpdatedV1", EthJson) do(
5050
update: ForkchoiceStateV1,
5151
payloadAttributes: Opt[PayloadAttributesV1]) -> ForkchoiceUpdatedResponse:
5252
info "engine_forkchoiceUpdatedV1",
@@ -58,7 +58,7 @@ proc setupEngineAPI*(server: RpcServer) =
5858
status: PayloadExecutionStatus.syncing))
5959

6060
# https://github.com/ethereum/execution-apis/blob/v1.0.0-beta.4/src/engine/shanghai.md#engine_forkchoiceupdatedv2
61-
server.rpc("engine_forkchoiceUpdatedV2") do(
61+
server.rpc("engine_forkchoiceUpdatedV2", EthJson) do(
6262
forkchoiceState: ForkchoiceStateV1, payloadAttributes: Opt[PayloadAttributesV2]) -> ForkchoiceUpdatedResponse:
6363
info "engine_forkchoiceUpdatedV2",
6464
forkchoiceState, payloadAttributes
@@ -67,22 +67,22 @@ proc setupEngineAPI*(server: RpcServer) =
6767
payloadStatus: PayloadStatusV1(
6868
status: PayloadExecutionStatus.syncing))
6969

70-
server.rpc("eth_getBlockByNumber") do(
70+
server.rpc("eth_getBlockByNumber", EthJson) do(
7171
quantityTag: string, fullTransactions: bool) -> JsonString:
7272
info "eth_getBlockByNumber", quantityTag, fullTransactions
7373

7474
return if quantityTag == "latest":
75-
JrpcConv.encode(BlockObject(number: 1000.Quantity)).JsonString
75+
EthJson.encode(BlockObject(number: 1000.Quantity)).JsonString
7676
else:
7777
"{}".JsonString
7878

79-
server.rpc("eth_getBlockByHash") do(
79+
server.rpc("eth_getBlockByHash", EthJson) do(
8080
data: string, fullTransactions: bool) -> BlockObject:
8181
info "eth_getBlockByHash", data = toHex(data), fullTransactions
8282

8383
return BlockObject(number: 1000.Quantity)
8484

85-
server.rpc("eth_chainId") do() -> UInt256:
85+
server.rpc("eth_chainId", EthJson) do() -> UInt256:
8686
info "eth_chainId"
8787

8888
return 1.u256

0 commit comments

Comments
 (0)