Skip to content

Commit c58607a

Browse files
authored
Merge pull request #1175 from maiko3tattun/240612_VisualCppErrorMessage2
Show error message to install Visual C++
2 parents 3a2ad5e + 3a323a1 commit c58607a

File tree

3 files changed

+8
-1
lines changed

3 files changed

+8
-1
lines changed

OpenUtau.Core/Render/RenderEngine.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,12 @@ public Tuple<WaveMix, List<Fader>> RenderMixdown(TaskScheduler uiScheduler, ref
107107
if (task.IsFaulted && !wait) {
108108
Log.Error(task.Exception.Flatten(), "Failed to render.");
109109
PlaybackManager.Inst.StopPlayback();
110-
var customEx = new MessageCustomizableException("Failed to render.", "<translate:errors.failed.render>", task.Exception);
110+
MessageCustomizableException customEx;
111+
if (task.Exception.Flatten().InnerExceptions.ToList().Any(e => e is DllNotFoundException)) {
112+
customEx = new MessageCustomizableException("Failed to render.", "<translate:errors.failed.render>: <translate:errors.install.cpp>", task.Exception);
113+
} else {
114+
customEx = new MessageCustomizableException("Failed to render.", "<translate:errors.failed.render>", task.Exception);
115+
}
111116
DocManager.Inst.ExecuteCmd(new ErrorMessageNotification(customEx));
112117
}
113118
}, CancellationToken.None, TaskContinuationOptions.OnlyOnFaulted, uiScheduler);

OpenUtau/Strings/Strings.axaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@
8787
<system:String x:Key="errors.failed.save">Failed to save</system:String>
8888
<system:String x:Key="errors.failed.savesingerconfig">Failed to save singer config file</system:String>
8989
<system:String x:Key="errors.failed.searchsinger">Failed to search singers</system:String>
90+
<system:String x:Key="errors.install.cpp">Try installing the latest Visual C++ Redistributable. https://learn.microsoft.com/en-US/cpp/windows/latest-supported-vc-redist?view=msvc-170</system:String>
9091
<system:String x:Key="errors.lyrics.regex">Character not allowed in regular expression</system:String>
9192
<system:String x:Key="errors.lyrics.regexpreview">- regular expression error -</system:String>
9293

OpenUtau/Strings/Strings.ja-JP.axaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@
8585
<system:String x:Key="errors.failed.save">保存に失敗しました</system:String>
8686
<system:String x:Key="errors.failed.savesingerconfig">シンガー設定の保存に失敗しました</system:String>
8787
<system:String x:Key="errors.failed.searchsinger">シンガーの取得に失敗しました</system:String>
88+
<system:String x:Key="errors.install.cpp">最新のVisual C++ランタイムをインストールしてください。 https://learn.microsoft.com/ja-JP/cpp/windows/latest-supported-vc-redist?view=msvc-170</system:String>
8889
<system:String x:Key="errors.lyrics.regex">正規表現に使用できない文字が含まれています</system:String>
8990
<system:String x:Key="errors.lyrics.regexpreview">- 正規表現エラー -</system:String>
9091

0 commit comments

Comments
 (0)