Configre CI for unittests

Author: kurlov

.github/workflows/go-test.yml

@@ -0,0 +1,24 @@
+name: Go Unit Tests
+
+on:
+  push:
+    paths:
+      - 'cmd/**'
+  pull_request:
+    paths:
+      - 'cmd/**'
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Go
+        uses: actions/setup-go@v5
+        with:
+          go-version-file: 'go.mod'
+
+      - name: Run tests
+        run: make go-test

Makefile

@@ -37,6 +37,9 @@ deps:
 generate-catalog-template: deps bundles.yaml
 	@$(GO) run ./cmd/generate-catalog/
 
+go-test: deps
+	@$(GO) test ./cmd/...
+
 $(OPM):
 	mkdir -p "$$(dirname $@)"
 	os_name="$$(uname | tr '[:upper:]' '[:lower:]')"; \

cmd/generate-catalog/generate_test.go

@@ -7,6 +7,34 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
+var (
+	v3610 = semver.MustParse("3.61.0")
+	v3620 = semver.MustParse("3.62.0")
+	v3621 = semver.MustParse("3.62.1")
+	v4000 = semver.MustParse("4.0.0")
+	v4001 = semver.MustParse("4.0.1")
+	v4002 = semver.MustParse("4.0.2")
+	v4100 = semver.MustParse("4.1.0")
+	v4101 = semver.MustParse("4.1.1")
+	v4200 = semver.MustParse("4.2.0")
+
+	entry3620 = newChannelEntry(v3620, v3610, v3610, nil)
+	entry3621 = newChannelEntry(v3621, v3620, v3610, nil)
+	entry4000 = newChannelEntry(v4000, v3621, v3620, nil)
+	entry4001 = newChannelEntry(v4001, v4000, v3620, []*semver.Version{v4001})
+	entry4002 = newChannelEntry(v4002, v4001, v3620, []*semver.Version{v4001})
+	entry4100 = newChannelEntry(v4100, v4002, v4000, []*semver.Version{v4001})
+	entry4101 = newChannelEntry(v4101, v4100, v4000, []*semver.Version{v4001})
+	entry4200 = newChannelEntry(v4200, v4101, v4100, []*semver.Version{v4001})
+
+	channel36     = newChannel(v3620, []ChannelEntry{entry3620, entry3621})
+	latestChannel = newLatestChannel([]ChannelEntry{entry3620, entry3621})
+	channel40     = newChannel(v4000, []ChannelEntry{entry4000, entry4001, entry4002})
+	channel41     = newChannel(v4100, []ChannelEntry{entry4000, entry4001, entry4002, entry4100, entry4101})
+	channel42     = newChannel(v4200, []ChannelEntry{entry4000, entry4001, entry4002, entry4100, entry4101, entry4200})
+	stableChannel = newStableChannel([]ChannelEntry{entry4000, entry4001, entry4002, entry4100, entry4101, entry4200})
+)
+
 func TestGenerateChannels(t *testing.T) {
 	// Define test cases
 	tests := []struct {
@@ -16,40 +44,29 @@ func TestGenerateChannels(t *testing.T) {
 		expectedChannels []Channel
 	}{
 		{
-			name: "Single major version with no broken versions",
-			versions: []*semver.Version{
-				semver.MustParse("4.0.0"),
-				semver.MustParse("4.0.1"),
-				semver.MustParse("4.1.0"),
-				semver.MustParse("4.1.1"),
-			},
-			brokenVersions:   nil,
-			expectedChannels: []Channel{
-				// Expected channels for the given versions
-			},
-		},
-		{
-			name: "Multiple major versions with broken versions",
+			name: "Multiple major versions with broken version",
 			versions: []*semver.Version{
-				semver.MustParse("3.61.0"),
-				semver.MustParse("4.0.0"),
-				semver.MustParse("4.0.1"),
-				semver.MustParse("4.1.0"),
-				semver.MustParse("5.0.0"),
+				v3620,
+				v3621,
+				v4000,
+				v4001,
+				v4002,
+				v4100,
+				v4101,
+				v4200,
 			},
 			brokenVersions: []*semver.Version{
-				semver.MustParse("4.0.1"),
+				v4001,
 			},
 			expectedChannels: []Channel{
-				// Expected channels for the given versions
+				*channel36,
+				latestChannel,
+				*channel40,
+				*channel41,
+				*channel42,
+				stableChannel,
 			},
 		},
-		{
-			name:             "Empty versions list",
-			versions:         []*semver.Version{},
-			brokenVersions:   nil,
-			expectedChannels: []Channel{},
-		},
 	}
 
 	for _, tt := range tests {

cmd/generate-catalog/types_test.go

@@ -22,16 +22,16 @@ func TestNewChannelEntry(t *testing.T) {
 		{
 			name:                   "Valid channel entry with no broken versions",
 			version:                "4.1.0",
-			previousEntryVersion:   "4.0.0",
+			previousEntryVersion:   "4.0.5",
 			previousChannelVersion: "4.0.0",
-			brokenVersions:         []string{},
+			brokenVersions:         nil,
 			expectedName:           "rhacs-operator.v4.1.0",
-			expectedReplaces:       "rhacs-operator.v4.0.0",
+			expectedReplaces:       "rhacs-operator.v4.0.5",
 			expectedSkipRange:      ">= 4.0.0 < 4.1.0",
-			expectedSkips:          []string{},
+			expectedSkips:          nil,
 		},
 		{
-			name:                   "Valid channel entry with broken versions",
+			name:                   "Valid channel entry with broken version",
 			version:                "4.2.0",
 			previousEntryVersion:   "4.1.0",
 			previousChannelVersion: "4.1.0",
@@ -41,23 +41,48 @@ func TestNewChannelEntry(t *testing.T) {
 			expectedSkipRange:      ">= 4.1.0 < 4.2.0",
 			expectedSkips:          []string{"rhacs-operator.v4.1.1"},
 		},
+		{
+			name:                   "Channel entry for version 2 minor version ahead of broken version which should not be in skips value",
+			version:                "4.5.0",
+			previousEntryVersion:   "4.4.5",
+			previousChannelVersion: "4.4.0",
+			brokenVersions:         []string{"4.1.1"},
+			expectedName:           "rhacs-operator.v4.5.0",
+			expectedReplaces:       "rhacs-operator.v4.4.5",
+			expectedSkipRange:      ">= 4.4.0 < 4.5.0",
+			expectedSkips:          nil,
+		},
 		{
 			name:                   "Version without replaces",
 			version:                "4.0.0",
 			previousEntryVersion:   "3.62.0",
 			previousChannelVersion: "3.62.0",
-			brokenVersions:         []string{},
+			brokenVersions:         nil,
 			expectedName:           "rhacs-operator.v4.0.0",
 			expectedReplaces:       "",
 			expectedSkipRange:      ">= 3.62.0 < 4.0.0",
-			expectedSkips:          []string{},
+			expectedSkips:          nil,
+		},
+		{
+			name:                   "Multiple broken versions",
+			version:                "4.3.0",
+			previousEntryVersion:   "4.2.0",
+			previousChannelVersion: "4.2.0",
+			brokenVersions:         []string{"4.2.1", "4.2.2"},
+			expectedName:           "rhacs-operator.v4.3.0",
+			expectedReplaces:       "rhacs-operator.v4.2.0",
+			expectedSkipRange:      ">= 4.2.0 < 4.3.0",
+			expectedSkips:          []string{"rhacs-operator.v4.2.1", "rhacs-operator.v4.2.2"},
 		},
 	}
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			version := semver.MustParse(tt.version)
-			previousEntryVersion := semver.MustParse(tt.previousEntryVersion)
+			var previousEntryVersion *semver.Version
+			if tt.previousEntryVersion != "" {
+				previousEntryVersion = semver.MustParse(tt.previousEntryVersion)
+			}
 			previousChannelVersion := semver.MustParse(tt.previousChannelVersion)
 
 			var brokenVersions []*semver.Version